[pt-BR] Sentences, responses and tests #1111
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dclobato
commented
Feb 23, 2023
dclobato
commented
- Change name to pt-BR, to be similar to fr-CA, de-CH
- Remove terms presents on _common.yaml and _fixture.yaml that only make sense on pt-PT
- Start sentences/tests/responses from scratch, instead of translating sentences from english/spanish
- Add file for sentences from scene, script and lock domains
-- Change name to pt-BR, to be similar to fr-CA, de-CH -- Remove terms presents on _common.yaml and _fixture.yaml that only make sense on pt-PT -- Start sentences/tests/responses from scratch, instead of translating sentences from english/spanish -- Add file for sentences from scene, script and lock domains
|
@synesthesiam, just did changes requested on previous PR |
|
@synesthesiam I don't get what's is going on... I changed the language code to pt-BR (same idea of fr-CA, e.g.). Removed the the old language files (using git), and added the new ones using the script for generating new language. Files that already exists on the previous version are still on the "pt-br" dir, despite the folder name on the file system is pt-BR. That's why lint is complaining... What should I change here to fix this? |
|
If some one want to solve this case-sense problem, be my guest and take ownership of this PR. I give up. |
|
I'm sorry, I haven't had a chance to look into this just yet 🫤 |
|
repo is archived |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.