Pt br leofig rj #1413
Pt br leofig rj #1413
Conversation
| name: "all" | ||
| response: fans_area | ||
| - sentences: | ||
| - "<desligar> (todo[s] [o[s]] ventilador[es] [da casa] | [todo[s]] [o[s]] ventilador[es] da casa)" |
There was a problem hiding this comment.
I think it makes no sense todo[s] and the two options inside (<OPTION_1> | <OPTION_2>) are basically the same, aren't they?
And since it's an action to turn all the fans off, [os] makes more sense than [o[s]]
What do you think of updating it to:
- sentences:
- "<desligar> [todos] [os] ventiladores [da casa]"
| name: "all" | ||
| response: fans_area | ||
| - sentences: | ||
| - "<ligar> (todo[s] [o[s]] ventilador[es] [da casa] | [todo[s]] [o[s]] ventilador[es] da casa)" |
There was a problem hiding this comment.
Same suggestion I left for the intent for turning off all the fans:
I think it makes no sense todo[s] and the two options inside (<OPTION_1> | <OPTION_2>) are basically the same, aren't they?
And since it's an action to turn all the fans on, [os] makes more sense than [o[s]]
What do you think of updating it to:
- sentences:
- "<ligar> [todos] [os] ventiladores [da casa]"
|
|
||
| # Max/Min brightness | ||
| - sentences: | ||
| - "<mudar_valor_numerico> [a] luminosidade <no_nome> [no] {brightness_level:brightness}" |
There was a problem hiding this comment.
Suggestion: replacing [no] with [no|em|para] since it makes sense to say:
Ajustar luminosidade da luz para 10 or even
Ajustar luminosidade da luz em 10
| # Max/Min brightness | ||
| - sentences: | ||
| - "<mudar_valor_numerico> [a] luminosidade <no_nome> [no] {brightness_level:brightness}" | ||
| - "<mudar_valor_numerico> [no|em] {brightness_level:brightness} [a] luminosidade <no_nome>" |
There was a problem hiding this comment.
Suggestion: replacing [no|em] with [no|em|para] since it makes sense to say:
Ajustar para 10 a luminosidade da luz
| response: brightness | ||
|
|
||
| - sentences: | ||
| - "<mudar_valor_numerico> [a] luminosidade <na_area> [no] {brightness_level:brightness}" |
There was a problem hiding this comment.
Suggestion: replacing [no] with [no|em|para] since it makes sense to say:
Ajustar luminosidade na sala para 10 or even
Ajustar luminosidade na sala em 10
|
Since there was no response at all, I'm declaring this PR stale and closing it. ../Frenck |
Updated intents: _common.yaml, light_HassTurnOn.yaml, light_HassTurnOff.yaml, light_HassLightSet.yaml, fan_HassTurnOn.yaml and fan_HassTurnOff.yaml.
Updated responses: HassTurnOn.yaml and HassLightSet.yaml.
In pt-br.