[PL] - big update for current intents and added new intents for cover, valve, vacuum, media_player, person, todo, weather and more

[witold-gren]

No description provided.

[Uriziel01]

@witold-gren I did a small lookaround and I do have some small remarks, give me few hours to write them down for you after 4PM. Sorry for the delay, I have a 3 week baby, hard to find any free time 🙂

[deejay1]

@Uriziel01 congrats and condolences at the same time, you won't have any free time for the next 10 years at least (speaking as a father of two ;)

[witold-gren]

Guys.. come on.. I have four children.. 😉 And as you can see, I'm not short on time..

Back to the business. I updated the person entities to make them more flexible when asking questions (I followed PR as example #1779). Today is the last day of my updates. I'm leaving tomorrow, so unfortunately I won't be able to update this PR. I won't be available until Monday.

[witold-gren]

Hey @Uriziel01 @synesthesiam,
since there are still no comments or urgent requests for any changes, please include this PR in the master version, as I would like it to be available in today's release. We can make some changes in the next PR if they will be required. I will also be unlocked to work on sensors and binary_sensors sentences.

[Uriziel01]

Hey @Uriziel01 @synesthesiam, since there are still no comments or urgent requests for any changes, please include this PR in the master version, as I would like it to be available in today's release. We can make some changes in the next PR if they will be required. I will also be unlocked to work on sensors and binary_sensors sentences.

I think I for once agree with that sentence, I'm going through it aws but in reality 80 files at the same time changed and refactered
within 61 commits makes it almost unreviewable properly. If you merge it before I'm finished that's fine, if I'm first and I find anything in this enormous pile that's also good. Win-win 🙂

[witold-gren]

Sorry, but unfortunately I don't have permission to merge any PR related with polish language.

[home-assistant]

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

[Uriziel01]

@witold-gren I've finished the very initial review, I'm sure there is more to fix but even going through it just with just a first glance took almost an hour and because the webUI of GitHub was not happy when jumping around through 6k+ lines of code in the diff 😁 It will have to cut it for now, just ping me when finished fixing/answering and I'll merge it, if I've missed something (and I'm very sure I did missed more bugs) I hope we will fix it on a later iteration as you've proposed. At least that's what I'm hoping for, time will tell 😉

[witold-gren]

Like I mentioned, now I'm unavailable until Monday. Big thanks for quick review. However, since this was not added to this version it not make a sens to close it with potential bugs. Now you can work on this PR calmly, let me know when you check everything and I will make corrections. 💪🏻

[Uriziel01]

@witold-gren Just add missing tests, then let me have a last look and I think we are good to go with this PR 🙂🥳

[witold-gren]

@Uriziel01 I improved the expressions related to Media Player so that there are no contains incorrect sentences. Take a look at this place.

[Uriziel01]

Thank you for your hard work.