Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EL] Greek initial support #236

Merged
merged 10 commits into from
Jan 5, 2023
Merged

[EL] Greek initial support #236

merged 10 commits into from
Jan 5, 2023

Conversation

dsimop
Copy link
Contributor

@dsimop dsimop commented Jan 3, 2023

No description provided.

@dsimop
Copy link
Contributor Author

dsimop commented Jan 3, 2023

The failing tests occur only because the recognition model cannot handle a specific case for , etc. - which happens always often in Greek for words whose gender is male. Let "word1 word2" be a name and "word3" a domain. In any case the logic is the same and the recognition model has to handle these entity_names as follows:

If there is any word in a name/domain ending with "ς", that character has to be omitted/skipped when reading a sentence/test. For instance: name: "word1 word2", "word1" ends with "ς". But the sentence/test must include that name without the aforementioned character "ς".

@dsimop dsimop changed the title [El] Greek initial support [EL] Greek initial support Jan 3, 2023
Copy link

@glogiotatidis glogiotatidis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work! 🎉

Translations are good. The failing tests are surfacing a problem in the parsing engine imho. We will need to have this flexibility with Greek (maybe other langs as well).

Here's a related issue:

An entity name is ανεμιστήρα οροφής (fan ceiling)
When we say a full sentence to turn it off we would add the word "the" between "fan" and "ceiling" and remove the trailing ς from the word before. I would become

κλείσε τον ανεμιστήρα **της** οροφής

Another example for φωτιστικό υπνοδωματίου (lamp bedroom)

κλείσε το φωτιστικό **του** υπνοδωματίου

here there's no trailing ς and thus none removed.

Thoughts on how to handle those scenarios?

@dsimop
Copy link
Contributor Author

dsimop commented Jan 5, 2023

The problems with the male genders mentioned above, have been resolved by adapting the name definitions. Even the case presented by @glogiotatidis is covered. That is a workaround and not the optimal solution, which is to update the recognition model itself.

@dsimop dsimop requested a review from glogiotatidis January 5, 2023 12:15
@balloob balloob merged commit ffc6af8 into home-assistant:main Jan 5, 2023
@dsimop dsimop deleted the el-support branch January 5, 2023 16:33
@dsimop dsimop restored the el-support branch January 5, 2023 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants