Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DE] Add some set timer variations #2534

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jpbede
Copy link
Member

@jpbede jpbede commented Nov 14, 2024

Add some variations for setting a timer e.g. "Stelle Timer auf eine Stunde" or "Stelle einen Pizza Timer auf eine Stunde"

Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jpbede
thanks for this nice addition ❤️
Let us make the auf|für variation consistent for all sentences. Updating the other test sentences would also be great, thx 👍

sentences/de/homeassistant_HassStartTimer.yaml Outdated Show resolved Hide resolved
sentences/de/homeassistant_HassStartTimer.yaml Outdated Show resolved Hide resolved
sentences/de/homeassistant_HassStartTimer.yaml Outdated Show resolved Hide resolved
tests/de/homeassistant_HassStartTimer.yaml Outdated Show resolved Hide resolved
tests/de/homeassistant_HassStartTimer.yaml Outdated Show resolved Hide resolved
tests/de/homeassistant_HassStartTimer.yaml Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft November 14, 2024 20:48
@jpbede jpbede marked this pull request as ready for review November 14, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants