Add tests, VSCode setup, and update dependencies #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
zacwest
commented
May 23, 2021
•
zacwest
commented
- Steals the dependencies bump from Bump Firebase Functions Version #50, and adds in more bumping.
- Adds launchable VSCode configs, which can run functions or tests, both with debugger.
- Adds GitHub CI infrastructure for calling tests and reporting code coverage.
- Adds basic tests for input/output of the legacy function.
- Standardizes our horribly-inconsistent semicolon usage, apply auto-fixes around it.
zacwest
changed the title
Codecov Report
@@ Coverage Diff @@
## master #55 +/- ##
=========================================
Coverage ? 34.59%
=========================================
Files ? 4
Lines ? 370
Branches ? 0
=========================================
Hits ? 128
Misses ? 242
Partials ? 0 Continue to review full report at Codecov.
|
zacwest
added a commit
to home-assistant/iOS
that referenced
this pull request
Jun 8, 2021
Refs #1382 and home-assistant/core#50750. ## Summary Uses (and requires) the core-2021.6 local push handling to subscribe to notification calls and show notifications without going through the Apple Push Notification Service. ## Screenshots | Light | Dark | | -- | -- | | <img width="712" alt="Screen Shot 2021-06-06 at 18 08 59" src="https://user-images.githubusercontent.com/74188/120946730-57a8d600-c6f2-11eb-8dde-b03b42a0a03a.png"> | <img width="712" alt="Screen Shot 2021-06-06 at 18 09 09" src="https://user-images.githubusercontent.com/74188/120946737-5d9eb700-c6f2-11eb-8563-8d9b8d8e075b.png"> | ## Link to pull request in Documentation repository Documentation: home-assistant/companion.home-assistant#539 ## Any other notes - Only works on macOS for this first round. The iOS implementation will be the same manager, but needs extensions scaffolding that I have to put together separately. - iOS will also likely have a setting to control this behavior, since it has potential battery implications; macOS doesn't have such concerns. - Adds tests around the parsing of the raw notification payloads that uses the same tests introduced in home-assistant/mobile-apps-fcm-push#55. - Shows the state of the local push connectivity in Notifications. With multi-server support, this will probably need to be broken down by server, or moved into the server-specific configurations. This also sets us up to support encrypted notifications, since we're now able to handle the service call's data without any kind of remote manipulation. Unfortunately Apple declined the entitlement which makes this extremely easy, so we'll still need to handle the "commands are unencrypted" nonsense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.