Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Intel specific CPU idle driver #2209

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

agners
Copy link
Member

@agners agners commented Nov 1, 2022

No description provided.

@agners agners added linux Linux kernel related issue board/generic-x86-64 Generic x86-64 Boards (like Intel NUC) labels Nov 1, 2022
@agners
Copy link
Member Author

agners commented Nov 1, 2022

This can save up to 5W on Intel NUC systems when idle.

@agners agners added the REL-9 label Nov 1, 2022
@unclehack
Copy link

This looks good.

You may also want to add this patch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.0.6&id=e400ad8b7e6a1b9102123c6240289a811501f7d9. AMD systems still have to use the generic CPU idle driver. This fix helps AMD systems.

@agners
Copy link
Member Author

agners commented Nov 2, 2022

You may also want to add this patch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.0.6&id=e400ad8b7e6a1b9102123c6240289a811501f7d9. AMD systems still have to use the generic CPU idle driver. This fix helps AMD systems.

I wonder why it did not got back-ported into stable kernels. I see that Ubuntu added it, so I am fine adding it as well.

That said, I did not find numbers on how much that affects power though. I am guessing its rather small in the end.

@agners agners merged commit e1559cd into home-assistant:dev Nov 2, 2022
@agners
Copy link
Member Author

agners commented Nov 2, 2022

Adding this patch with #2210

@agners agners deleted the enable-intel-idle-driver branch November 2, 2022 10:08
@unclehack
Copy link

You may also want to add this patch https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git/commit/?h=v6.0.6&id=e400ad8b7e6a1b9102123c6240289a811501f7d9. AMD systems still have to use the generic CPU idle driver. This fix helps AMD systems.

I wonder why it did not got back-ported into stable kernels. I see that Ubuntu added it, so I am fine adding it as well.

That said, I did not find numbers on how much that affects power though. I am guessing its rather small in the end.

It's most likely something which avoids erratic behavior. I'm not sure how that workaround impacted VMs running on machines with AMD processors all of these years. It's not going to yield a performance improvement or reduced CPU usage.

agners added a commit that referenced this pull request Nov 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
board/generic-x86-64 Generic x86-64 Boards (like Intel NUC) cla-signed linux Linux kernel related issue REL-9
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants