Decrease network size of Docker default bridge (#2135) #2246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvizeli
approved these changes
Nov 25, 2022
agners
changed the title
|
This relates to #2135. |
|
The class b private adresses can go from 172.16.0.0 - 172.31.255.255 maybe picking the a space like 172.25.0.0/16 would slim the chances of someone using that subnet. |
|
@SolarstormTM right good point, we use |
agners
added a commit
to agners/operating-system
that referenced
this pull request
Dec 10, 2022
Use a subnet in the same class B network for the Docker default bridge is using. This avoids conflicting with more than one class B network.
|
PR #2259 |
agners
added a commit
that referenced
this pull request
Dec 10, 2022
|
It would be helpful to also mention the range change in the title because it broke by SSH Port Forwarding Addon :) |
|
@dilorenzo1987 fixed via ThomDietrich/home-assistant-addons#11 Thanks @hnykda |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of allocating
172.17.0.0/16as the default network bridge use a much smaller range. This helps folks which have hosts in that network range.Ideally, we should make the default as well as the hassio bridge configurable.