Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new containerd.sock location of Docker 23.0 #2382

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

agners
Copy link
Member

@agners agners commented Mar 3, 2023

Otherwise the Supervisor service fails to start with the following error:

Mar 03 09:13:23 ha-yellow-desk hassos-supervisor[843]: Error response from daemon: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: error during container init: error mounting "/run/docker/containerd/containerd.sock" to rootfs at "/run/docker/containerd/containerd.sock": mount /run/docker/containerd/containerd.sock:/run/docker/containerd/containerd.sock (via /proc/self/fd/6), flags: 0x5000: not a directory: unknown: Are you trying to mount a directory onto a file (or vice-versa)? Check if the specified host path exists and is the expected type

Which ultimately leads to re-download of the Supervisor because the script assumes it crashed.

With this change, the container image will not get redownloaded. But because the script date changed, it will lead to recreation of the container (with the new bind mount location).

Note: We currently don't use this socket in Supervisor. Rather than maintain the old location, just move it to the new location also inside the Supervisor container.

@agners agners added os and removed cla-signed labels Mar 3, 2023
@agners agners merged commit ca6bccb into dev Mar 3, 2023
@agners agners deleted the use-new-containerd-sock-location branch March 3, 2023 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant