Don't fail if apparmor_parser is missing #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently a missing apparmor_parser binary leads to a panic at startup already since the property value gets evaluated when the propery is registred. Set the property to an empty string if apparmor_parser is missing. This will allow to generate a sensible warning in Supervisor so the user can act on it.
ludeeus
approved these changes
Oct 4, 2021
|
Sentry issue: OS-AGENT-1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a missing apparmor_parser binary leads to a panic at startup
already since the property value gets evaluated when the propery is
registred.
Set the property to an empty string if apparmor_parser is missing. This
will allow to generate a sensible warning in Supervisor so the user can
act on it.