Skip to content
This repository has been archived by the owner on Oct 4, 2019. It is now read-only.

Conditional cards in vertical stack take up space when hidden #169

Closed
john-ruddy opened this issue Sep 24, 2018 · 5 comments
Closed

Conditional cards in vertical stack take up space when hidden #169

john-ruddy opened this issue Sep 24, 2018 · 5 comments

Comments

@john-ruddy
Copy link

I stacked up a bunch of conditional cards with messages about the status of my gate sensors and found out they take up space even when they're not shown if they're inside a vertical stack
image

I moved them outside the vertical-stack and the space went away. The margin space they take up is because of the css rule #root > * { : 4px 0 8px 0; } from the style tag inside the hui-vertical-stack-card element.

@john-ruddy
Copy link
Author

On a related note, if a column in a horizontal stack contains only hidden cards it does not get hidden.

I understand that lovelace is in very early phases and that these seem like picky things to point out but I promise that I'm trying to be helpful not annoying. I do not think these issues are urgent.

@jeradM
Copy link
Member

jeradM commented Sep 25, 2018

Geez stop being so annoying 😉 but seriously, this has been an issue for a while and I'll try to get it fixed today. I think this is a duplicate of #127, but I'm going to leave it open for now since it is specifically about the vertical-stack card so I don't forget to test it there

@john-ruddy
Copy link
Author

My second comment is definitely a duplicate of 127 but I haven't dug into things far enough to know if they would be fixed by the same thing

@jeradM
Copy link
Member

jeradM commented Sep 25, 2018

I suspect that fixing 127 will solve both of these issues

@iantrich
Copy link
Member

iantrich commented Nov 7, 2018

Resolved: home-assistant/frontend#1999

@iantrich iantrich closed this as completed Nov 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants