Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make conditional not take up space in stacks when hidden #1999

Merged
merged 2 commits into from
Nov 6, 2018

Conversation

thomasloven
Copy link
Contributor

Conditional left a gap between cards when hidden if in a vertical-stack.
Restoring old solution.

@ghost ghost assigned thomasloven Nov 6, 2018
@ghost ghost added the in progress label Nov 6, 2018
@ghost ghost assigned balloob Nov 6, 2018
@balloob
Copy link
Member

balloob commented Nov 6, 2018

I added a comment so it survives the next refactor 😛

@balloob balloob modified the milestones: 20181103.1, 20181103..2 Nov 6, 2018
@thomasloven
Copy link
Contributor Author

Good idea

@balloob balloob merged commit 54e4375 into dev Nov 6, 2018
@ghost ghost removed the in progress label Nov 6, 2018
@balloob balloob deleted the conditional-card-fix branch November 6, 2018 11:39
balloob pushed a commit that referenced this pull request Nov 7, 2018
* Make conditional not take up space in stacks when hidden

* Update hui-conditional-card.ts
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants