Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notification Counter Badge not working #1695

Open
vaskion opened this issue Jun 11, 2022 · 22 comments
Open

Notification Counter Badge not working #1695

vaskion opened this issue Jun 11, 2022 · 22 comments
Labels

Comments

@vaskion
Copy link

vaskion commented Jun 11, 2022

Things to do first

  • The problem is still happening even when I leave only Dash-to-Panel extension running and all other are disabled.
  • I executed the command mentioned above but there were no errors shown.
  • I also searched through the list of issues but was not able to find a similar one.

Describe the bug
'Dash to Panel Settings' -> 'Behavior' -> 'Show notification counter badge' option does not work for me. When I enable it and have unread messages from Google Chrome inbox, Google Chat app, MS Teams or other notifications from any running app they are not shown as badges on the corresponding app indicator on the panel. Attached is a screenshot showing some notifications from Google Chat app and in the background I have several unread e-mail in the inbox. I also attached the exported settings of the Dash-to-Panel extension.

Linux distribution and version
OS Name: Ubuntu 22.04 LTS
Linux kernel: 5.15.0-37-generic #39-Ubuntu SMP Wed Jun 1 19:16:45 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

GNOME Shell version
GNOME Shell 42.1

Dash-to-Panel version
Dash-to-Panel version: 50

Where was Dash-to-Panel installed from?
The GNOME extensions website:
https://extensions.gnome.org/extension/1160/dash-to-panel/

Screenshots / Video captures
Screenshot from 2022-06-11 13-20-48
settings_dash_to_dock.txt

Additional Info

  • I looked at the source code and saw that the Dash-to-Panel is actually registering for some events coming through 'org.freedesktop.DBus' but it seems that not all apps are posting their unread messages count and/or notifications through it. Some of the apps are just popping messages to the message tray. Do I miss some library or package for this to work properly?
  • I also saw that the Dash-to-Panel is not registering for any notifications coming from the message tray. I modified the code in 'progress.js' and Injected a callback function to handle events from the message tray. In this callback I update the 'unreadCount' per application and show the counter badge bin. This worked for me so far to show notifications from Google, MS Teams and other apps that pop directly to the message tray. Please let me know if you would like me to share my mods with you.

Thank you,
Vasil Krastev

@vaskion vaskion added the bug label Jun 11, 2022
@MindlessDreams
Copy link

Hello, Vasil, kindly share the modifications here. Thanks!

@vaskion
Copy link
Author

vaskion commented Jun 20, 2022

Hello, Vasil, kindly share the modifications here. Thanks!

Hello,

Attached you will find my version of 'progress.js' file. Just rename it from .txt to .js as it didn't allow me to upload the .js file directly.
I added the _updateBadge() callback function and another one _fillAnimationProperties() to fill animation effect for some popup effect on the counters when they appear/disappear. Then in your toggleNotificationBadge() function I commented the original code and added mine. I think the original code will still work even with my mods.

Best regards,
Vasil

progress.txt

@MindlessDreams
Copy link

Hello, Vasil, thanks for sending it. It does work - notification badges do appear. There are some issues though - for example the Thunderbird (flatpak) notifications does not seem to clear when the emails are open. Viber (flatpak) notifications appear and are cleared right after that regardless if the message is opened or not...I suppose this might be because of the flatpak's setup. Thanks again! Благодаря :)

@vaskion
Copy link
Author

vaskion commented Jun 20, 2022

Няма защо! :-) I am glad it worked for you too.

Actually I have tested it with the apps that I mainly use as this was just my modification to fix the things I missed.
For example with the Google Chat app there is also an inconsistency. Because it does not detect every time correctly the standalone application and sometimes shoes the badge on the Chrome browser instead. But I could not fix it as this is how the google apps handle the notifications and they send them directly to the message tray.

I guess there is something similar with the Thunderbird and Viber. When the item is cleared from the message tray then the badge is cleared as well. I could not find a way to track the app itself. This was the easiest way to get what I missed until the issue is fixed in the extensions by the authors.

Best regards!

PS I think this is something very basic that should be supported by the OS itself and not having us write our own extensions to have it...

@xalt7x
Copy link
Contributor

xalt7x commented Oct 19, 2022

@vaskion ,
Any chance to upstream this? It worked really well for me.
The only annoyance I've got was with "Nautilus" file copy.
Here's how to reproduce it:

  1. Create some large file with "fallocate" terminal command
    fallocate -l 4G 4GbEmptyFile
  2. Copy/Paste it somewhere (even in the same folder)
  3. While it copies switch to some other application
  4. After copy, badge will appear at Nautilus icon. And it won't go away when you switch to Nautilus.
    You have to either remove this notification at the "clock"/notification menu or close all Nautilus windows.

The only other GNOME "panel" extension I've found with a similar feature was "Rocketbar". Other alternative could be "Notification Counter"

@stale
Copy link

stale bot commented Apr 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 18, 2023
@Merrit
Copy link

Merrit commented Jul 19, 2023

Is there something specific holding this issue up?

Copy link

stale bot commented Jan 16, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 16, 2024
@bathwaterpizza
Copy link

So far I haven't seen any app with notification bubbles working. Discord for instance does not show bubbles when using dash to panel, and it's installed natively with pacman.

@stale stale bot removed the stale label Jan 19, 2024
@myryk31415
Copy link

same here on Opensuse Tumbleweed, there is no notification counter badge, installed via the gnome extension website

@Ki-wimon
Copy link

Ki-wimon commented Mar 17, 2024

same problem with Discord here

@grloch
Copy link

grloch commented Mar 19, 2024

Having the same problem here, no badges at all

@NickBelhomme
Copy link

same here on Opensuse Tumbleweed, there is no notification counter badge, installed via the gnome extension website

@Zeoic
Copy link

Zeoic commented Apr 24, 2024

Something I have noticed when going from Zorin OS 16 to Ubuntu 24.04, is that my issues with the embled have swapped. Previously on Zorin 16 (which has a much older version of gnome) Slack had emblems, but discord did not. Now on Ubuntu 24.04 its the other way around, Discord has emblems and Slack does not. It is rather strange. Would be awesome to have all apps have working emblems / indicators :P

In this image both discord and slack have a new message and there are currently notifications sitting in the notification center
image

@Modiete
Copy link

Modiete commented May 16, 2024

Same with whatsapp in gnome.. i can't get notifications when a message comes

@JayeshInfowind
Copy link

JayeshInfowind commented Jun 13, 2024

WHere to fing progress.js file I want to add your modification please help @vaskion

@vaskion
Copy link
Author

vaskion commented Jun 13, 2024

WHere to fing progress.js file I want to add your modification please help @vaskion

It is in the extension installation folder. But my fix may no longer work depending on which OS you are currently running. They messed the whole thing up from Ubuntu 22.10 onwards...

@Malix-Labs
Copy link

I didn't know it was an already implemented (but not working) feature, hence I mistakenly created the (now closed as duplicate) #2122

@erikhakansson
Copy link

Any news on this?

@influential-eliot
Copy link

I am also seeing this issue.
OS: Debian 12
Windowing System: Wayland
Gnome Version: 43.9
D2P Version: 56

On the version of the ext, I can see that there appear to be a few newer versions in this repo, but when I go to extensions.gnome.org it sees no update required.
image

@aaryan6789
Copy link

Is there an update on this bug ? Would it be fixed soon or if there is a workaround for this for Ubuntu 24.04/ Gnome 46 ?

@JayeshInfowind
Copy link

Is there an update on this bug ? Would it be fixed soon or if there is a workaround for this for Ubuntu 24.04/ Gnome 46 ?

No

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests