feat: Add GridColumn.showIn for csv-only columns. #1109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephenh
commented
Jan 30, 2025
| @@ -249,23 +249,21 @@ export class GridTableApiImpl<R extends Kinded> implements GridTableApi<R> { | |||
| const csvPrefixRows = this.tableState.csvPrefixRows?.map((row) => row.map(escapeCsvValue).join(",")) ?? []; | |||
| // Convert the array of rows into CSV format | |||
| const dataRows = this.tableState.visibleRows.map((rs) => { | |||
| const values = this.tableState.visibleColumns | |||
| .filter((c) => !c.isAction) | |||
There was a problem hiding this comment.
This is mostly whitespace changes, the only real change is this !c.isAction moved into the new visibleCsvColumns method.
stephenh
force-pushed
the
feat-csv-only-columns
branch
from
499b96e to
f4eb3e0
Compare
homebound-team-bot
pushed a commit
that referenced
this pull request
Jan 30, 2025
## [2.378.0](v2.377.3...v2.378.0) (2025-01-30) ### Features * Add GridColumn.showIn for csv-only columns. ([#1109](#1109)) ([80836e6](80836e6))
|
🎉 This PR is included in version 2.378.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.