Fix 'Locking...' and 'Unlocking...' issue #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a lock is unlocked or locked manually, the event is correctly sent to the plugin, and the current state is updated. The lock target state also needs to be updated to match the current state.
|
Ready to help test as soon as this is available in the 1.2 beta release. I use DoorSense. |
donavanbecker
approved these changes
Jul 26, 2023
Merged
donavanbecker
added a commit
that referenced
this pull request
Aug 19, 2023
## [Version 1.2.0](https://github.com/donavanbecker/homebridge-august/releases/tag/v1.2.0) (2023-08-19) ## What's Changes - Fixed debugging issue, Thanks [@dacarson](https://github.com/dacarson) [#69](#69) - Reduce August API calls, Thanks [@dacarson](https://github.com/dacarson) [#69](#69) - Fix 'Locking...' and 'Unlocking...' issue, Thanks [@dacarson](https://github.com/dacarson) [#66](#66) - Default Refresh Rate has been updated to limit the rate at which we refresh from August APIs. - This should fix any Status 429 Errors. [#55](#55) **Full Changelog**: v1.1.1...v1.2.0
donavanbecker
added a commit
that referenced
this pull request
Aug 19, 2023
## [Version 1.2.0](https://github.com/donavanbecker/homebridge-august/releases/tag/v1.2.0) (2023-08-19) ## What's Changes - Fixed debugging issue, Thanks [@dacarson](https://github.com/dacarson) [#69](#69) - Reduce August API calls, Thanks [@dacarson](https://github.com/dacarson) [#69](#69) - Fix 'Locking...' and 'Unlocking...' issue, Thanks [@dacarson](https://github.com/dacarson) [#66](#66) - Default Refresh Rate has been updated to limit the rate at which we refresh from August APIs. - This should fix any Status 429 Errors. [#55](#55) **Full Changelog**: v1.1.1...v1.2.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a lock is unlocked or locked manually, the event is correctly sent to the plugin, and the current state is updated. The lock target state also needs to be updated to match the current state.
♻️ Current situation
As the Target state is not updated, it is stale, and reflects the last state of the lock. Which is often the opposite of the new Current state. So in the HomeKit UIs it will show that the lock is currently transitioning from the Current state to the Target state, and the UI will be stuck there until the user either uses HomeKit to change the lock state, or manually restores the lock to the previous state.
💡 Proposed solution
When the event arrives that the user has manually changed the lock state, also update the Target lock state to match.
⚙️ Release Notes
Fixes issue #22 where manual lock changes result in Home app showing the lock stuck in transition mode.
Testing
Manually tested on my Homebridge setup with two August Locks (AUG-SL04-M01-G04) that do not have DoorSense setup. Manual testing included:
Reviewer Nudging
Focus on when a lock state change happens externally to HomeKit.