-
-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fan] Change Rotation Speed from percentage to levels #534
Conversation
Oh wow I did not even know this scale/functionality was available in HAP. Might look into changing my other plugins too! Out of interest, if you are using the existing version of the plugin with % scales, then change git branch to your changes, does the scale automatically update in the home app? or does it require removing the accessory for it to be re-added with the new scales? |
This is really cool, thank you |
@vadimpronin I was hoping you could check something further for me. (I do not have an iFan myself)
Would you be able to confirm that it works in the Homebridge UI? ie - not displaying a % and also it sliding properly between 0 - 1 - 2 - 3? |
Hey @bwp91
The scale updates automatically after a few minutes
Being able to change the scale in the UI is cool! |
Can you try deleting and re-adding the accessory in the Home app? |
I did that. Also deleted and re added the bridge in HomeKit. No change unfortunately
Regards
Dave
…________________________________
From: Vadim Pronin ***@***.***>
Sent: Friday, June 14, 2024 2:16:45 AM
To: bwp91/homebridge-ewelink ***@***.***>
Cc: swdwi2 ***@***.***>; Comment ***@***.***>
Subject: Re: [bwp91/homebridge-ewelink] [Fan] Change Rotation Speed from percentage to levels (PR #534)
Can you try deleting and re-adding the accessory in the Home app?
—
Reply to this email directly, view it on GitHub<#534 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ALY4IS66BR3FNDKMIMTQL3DZHKYH3AVCNFSM6AAAAABJEXULP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRXGYYDQMJXGQ>.
You are receiving this because you commented.Message ID: ***@***.***>
|
This PR changes units for Rotation Speed of a Fan from
%
tospeed levels
.Sonoff fans have only 3 speed settings presented as Roman numerals on the remote (
I
,II
,III
).Original implementation presented these levels as
33%
,66%
and99%
in HAP.Changing them to
1
,2
and3
seems more intuitive and inline with original sonoff design