v2.1.6 #843
Merged
v2.1.6 #843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| this.hostname = query.get('host') as string | ||
| const redirectUrl = `http://${this.hostname}:8585/auth` | ||
| const authUrl = `https://api.honeywell.com/oauth2/authorize?response_type=code&appSelect=1&redirect_uri=${encodeURI(redirectUrl)}&client_id=${query.get('key')}` | ||
| res.end(`<script>window.location.replace('${authUrl}');</script>`) |
Check failure
Code scanning / CodeQL
Reflected cross-site scripting High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 3 months ago
To fix the reflected cross-site scripting vulnerability, we need to ensure that any user-controlled data included in the HTML response is properly sanitized. The best way to achieve this is by using a library designed for escaping HTML content, such as escape-html.
- Import the
escape-htmllibrary to handle HTML escaping. - Use the
escape-htmlfunction to sanitize theauthUrlbefore embedding it in the HTML response.
Suggested changeset
2
src/homebridge-ui/server.ts
| @@ -5,2 +5,3 @@ | ||
| import util from 'node:util' | ||
| import escapeHtml from 'escape-html' | ||
|
|
||
| @@ -36,4 +37,4 @@ | ||
| const redirectUrl = `http://${this.hostname}:8585/auth` | ||
| const authUrl = `https://api.honeywell.com/oauth2/authorize?response_type=code&appSelect=1&redirect_uri=${encodeURI(redirectUrl)}&client_id=${query.get('key')}` | ||
| res.end(`<script>window.location.replace('${authUrl}');</script>`) | ||
| const authUrl = `https://api.honeywell.com/oauth2/authorize?response_type=code&appSelect=1&redirect_uri=${encodeURI(redirectUrl)}&client_id=${escapeHtml(query.get('key'))}` | ||
| res.end(`<script>window.location.replace('${escapeHtml(authUrl)}');</script>`) | ||
| break |
package.json
Outside changed files
| @@ -74,3 +74,4 @@ | ||
| "rxjs": "^7.8.1", | ||
| "undici": "^6.20.1" | ||
| "undici": "^6.20.1", | ||
| "escape-html": "^1.0.3" | ||
| }, |
This fix introduces these dependencies
| Package | Version | Security advisories |
| escape-html (npm) | 1.0.3 | None |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.1.6 (2024-10-24)
What's Changes
Full Changelog: v2.1.5...v2.1.6