Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure updateCharacteristic and setCharacteristic method signatures are in sync with updateValue and setValue. #981

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

Supereg
Copy link
Member

@Supereg Supereg commented Nov 1, 2022

♻️ Current situation

Currently, updateCharacteristic and setCharacteristic (Service class) don't expose the same method signature as updateValue and setValue (Characteristic class) methods. This was reported in #974.

💡 Proposed solution

This PR adapts the method signatures and adds proper documentation.

⚙️ Release Notes

  • Ensure that updateCharacteristic and setCharacteristic (Service class) method signatures are in sync with updateValue and setValue (Characteristic class) methods.

➕ Additional Information

This PR fixes some spelling mistakes.

Testing

--

Reviewer Nudging

--

…re in sync with updateValue and setValue.

Added documentation and fixed some spellin mistakes.
@github-actions github-actions bot added the fix label Nov 1, 2022
@coveralls
Copy link

coveralls commented Nov 1, 2022

Pull Request Test Coverage Report for Build 3368062083

  • 3 of 4 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 51.913%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/lib/Service.ts 2 3 66.67%
Totals Coverage Status
Change from base Build 3359159946: 0.0%
Covered Lines: 5820
Relevant Lines: 10247

💛 - Coveralls

@Supereg Supereg merged commit deeb8d1 into beta-0.11.0 Nov 1, 2022
@Supereg Supereg deleted the fix/characteristic-method-signature branch November 1, 2022 15:46
Supereg added a commit that referenced this pull request Nov 18, 2022
…re in sync with updateValue and setValue. (#981)

Added documentation and fixed some spellin mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants