Ensure updateCharacteristic and setCharacteristic method signatures are in sync with updateValue and setValue. #981
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Currently,
updateCharacteristic
andsetCharacteristic
(Service
class) don't expose the same method signature asupdateValue
andsetValue
(Characteristic
class) methods. This was reported in #974.💡 Proposed solution
This PR adapts the method signatures and adds proper documentation.
⚙️ Release Notes
updateCharacteristic
andsetCharacteristic
(Service
class) method signatures are in sync withupdateValue
andsetValue
(Characteristic
class) methods.➕ Additional Information
This PR fixes some spelling mistakes.
Testing
--
Reviewer Nudging
--