Add support for IPv4-mapped IPv6 addresses #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjdhjd
reviewed
Jul 1, 2024
hjdhjd
reviewed
Jul 1, 2024
hjdhjd
reviewed
Jul 1, 2024
hjdhjd
reviewed
Jul 1, 2024
|
i’m afraid i won’t be a good reviewer of this as (1) i don’t enough about this subject and best practises etc and (2) i cant even reproduce locally to check whether the changes is general work or not! |
|
@hjdhjd, Homebridge v1.8.4-alpha.18 has these changes and looks like it is working as expected. I will remove my commented out sections. |
donavanbecker
force-pushed
the
ipv4mapped2ipv6
branch
from
723e3d0 to
25a1215
Compare
Pull Request Test Coverage Report for Build 9816393432Details
💛 - Coveralls |
donavanbecker
requested review from
hjdhjd
and removed request for
Supereg,
NorthernMan54 and
bwp91
hjdhjd
approved these changes
Jul 6, 2024
Merged
donavanbecker
changed the title
donavanbecker
added a commit
that referenced
this pull request
Jul 9, 2024
## v1.3.0 (2024-07-08) ### Added - Add support for publishing on IPv6 networks (#19) (@adriancable) - Add support for IPv4-mapped IPv6 addresses (#43) (@donavanbecker & @hjdhjd) ### Changed - update dependencies - update dependencies, fix typedoc (#44) - update changelog, fix lint - Fix: minor housekeeping. (#48) (@@hjdhjd)
donavanbecker
added a commit
that referenced
this pull request
Jul 9, 2024
donavanbecker
added a commit
that referenced
this pull request
Jul 9, 2024
## v1.3.0 (2024-07-08) ### Added - Add support for publishing on IPv6 networks (#19) (@adriancable) - Add support for IPv4-mapped IPv6 addresses (#43) (@donavanbecker & @hjdhjd) ### Changed - update dependencies - update dependencies, fix typedoc (#44) - update changelog, fix lint - Fix: minor housekeeping. (#48) (@@hjdhjd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
♻️ Current situation
Currently IPv4-mapped IPv6 addresses are not supported
💡 Proposed solution
Add support for IPv4-mapped IPv6 addresses
⚙️ Release Notes
Added support for IPv4-mapped IPv6 addresses
➕ Additional Information
Not sure if there is anything else that needs to be changed?
Testing
Install tvOS 18 or macOS 15 beta
or
a device that has an IPv4-mapped IPv6 address.
Reviewer Nudging
tvOS 18 is what is causing the issue indicated in #41, but others have reported it with macOS 15 beta.