add resolved Advertiser to UI #1427
Conversation
There was a problem hiding this comment.
Thanks for addressing this so fast 🚀
The resolved option is still considered experimental as of right now.
- For one, there are still issues falling back when it is not available (see Doesn't fallback from systemd-resolved advertiser if MulticastDNS is disabled. HAP-NodeJS#980 (comment)).
- Also the original PR described that there are manual setup steps which are required to do beforehand to allow homebridge permissions (see Add systemd-resolved mDNS advertiser support HAP-NodeJS#965).
- Lastly, the advertisement is lost once the systemd-resolved daemon is restarted (see Add systemd-resolved mDNS advertiser support HAP-NodeJS#965 (comment)).
So, I would probably go with adding a (experimental) tag begin the option name. And then document the setup procedure and possible issues (e.g. lost advertisement on restarts and initial configuration) on the mDNS options Wiki page (https://github.com/homebridge/homebridge/wiki/mDNS-Options). I think that is probably the most user friendly way of handling that right now. This allows expert users to user the new feature, but don't overwhelm or make it too complicated for unexperienced users.
What's your view on this @oznu.
| @@ -131,6 +132,7 @@ export class SettingsComponent implements OnInit { | |||
| this.$settings.env.runningInPackageMode | |||
| ) { | |||
| this.showAvahiMdnsOption = true; | |||
| this.showResolvedMdnsOption = true; | |||
There was a problem hiding this comment.
Please only show the resolved option if the homebridge version is 1.6.0-beta.0 (the planned homebridge release to include hap-nodejs 0.11.0) or higher, as above.
EDIT: See few lines above how the avahi mdns option is only enabled for 1.4.0-beta.0 releases of homebridge.
Support for HAP-NodeJS Resolved Advertiser : https://github.com/homebridge/HAP-NodeJS/pull/965/files