Fix dropdown

[mkz212]

No description provided.

[donavanbecker]

@mkz212 Can you resolve the conflict

[mkz212]

@donavanbecker @bwp91 I need your help with this. The function at the bottom works great. But. The point is to exclude from this function click on dropdown.

[bwp91]

There is a conflict here again, please can you fix this, and what is it you need help with?

[mkz212]

// ensure the menu closes when we navigate
    router.events.subscribe((event) => {
      if (event instanceof NavigationEnd) {
        const dropdownMenu = window.document.querySelector('#navbarSupportedContent');
        const hamburgerMenuButton = window.document.querySelector('.navbar-toggler');
        if (dropdownMenu) {
          dropdownMenu.classList.remove('show');
          hamburgerMenuButton.classList.add('collapsed');
        }
      }
    });

this function works great. ( I added hamburgerMenuButton.classList.add('collapsed'); because it is nessesery to animate hamburger icon to X icon) But... I want to exclude click on dropdown in menu (class="toggle-dropdown") because now instead of open dropdown it close menu.

[bwp91]

I think im confusing menus - can you take a video of the current issue?

[mkz212]

const dropdownMenu should be const navbar - I don't know why it was a dropdown because it refers to the main menu

[bwp91]

In the code this is still a link

          <a class="nav-link dropdown-toggle" href="#" role="button">
            <i class="fa fa-cog pr-2"></i>Homebridge Settings<i class="fa fa-caret-down pl-2"></i>
          </a>

maybe it should be a button?

[mkz212]

@bwp91 Ok done! I changed to button. Can you merge?

[bwp91]

is it working now?

[mkz212]

is it working now?

It should. Can you merge? And release next alpha?