Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FirmwareRevision fixes #3644

Merged
merged 2 commits into from
Jul 6, 2024
Merged

FirmwareRevision fixes #3644

merged 2 commits into from
Jul 6, 2024

Conversation

hjdhjd
Copy link
Contributor

@hjdhjd hjdhjd commented Jul 6, 2024

♻️ Current situation

Currently, Homebridge sets the FirmwareRevision characteristic prospectively before instantiating an accessory. Further, if the firmware revision is “0.0.0” it forces the firmware revision to be the same as the current version number of the plugin. This causes a number of problems. If you have a plugin that has a high version number, let’s say 5.0.0 and the accessory has a firmware revision of 2.0.0, HomeKit will not process that change. Why? HomeKit rules state that firmware revisions can only increase in number, never decrease. The minimum version number supported is “0”.

💡 Proposed solution

Homebridge should not proactively set the FirmwareRevision characteristic to any other value than “0” and allow the plugin to manage firmware revisions.

⚙️ Release Notes

FirmwareRevision characteristic will be initialized to “0” on accessories.

@coveralls
Copy link

coveralls commented Jul 6, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 9814989597

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 28.178%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/bridgeService.ts 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/bridgeService.ts 1 21.76%
Totals Coverage Status
Change from base Build 9626810783: 0.2%
Covered Lines: 426
Relevant Lines: 1366
💛 - Coveralls

@donavanbecker donavanbecker merged commit c2a19eb into latest Jul 6, 2024
9 checks passed
@donavanbecker donavanbecker deleted the hjd-minor-fixes branch July 6, 2024 12:54
@donavanbecker donavanbecker mentioned this pull request Jul 11, 2024
Closed
This was referenced Jul 14, 2024
Closed
Merged
donavanbecker added a commit that referenced this pull request Jul 19, 2024
@donavanbecker
v1.8.4
758a931 
## v1.8.4 (2024-07-19)

### Fixed

- Fix default FirmwareRevision (#3644) (@hjdhjd)

### Changed

- Detect config interface on registerPlatform (#3609) (@duddu)
- Updated dependencies, fix `typedoc` generation
- Added log messaging about upcoming Homebridge v2.0.0 update
  - NOTICE TO USERS AND PLUGIN DEVELOPERS
    - Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
    - Please visit the following link to learn more about the changes and how to prepare:
      - [Updating-To-Homebridge-v2.0](https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0)
donavanbecker added a commit that referenced this pull request Jul 19, 2024
@donavanbecker
v1.8.4
760ba6f 
- Fix default FirmwareRevision (#3644) (@hjdhjd)

- Detect config interface on registerPlatform (#3609) (@duddu)
- Updated dependencies, fix `typedoc` generation
- Added log messaging about upcoming Homebridge v2.0.0 update
  - NOTICE TO USERS AND PLUGIN DEVELOPERS
    - Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
    - Please visit the following link to learn more about the changes and how to prepare:
      - [Updating-To-Homebridge-v2.0](https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0)
donavanbecker added a commit that referenced this pull request Jul 19, 2024
@donavanbecker
v1.8.4
bfd209f 
- Fix default FirmwareRevision (#3644) (@hjdhjd)

- Detect config interface on registerPlatform (#3609) (@duddu)
- Updated dependencies, fix `typedoc` generation
- Added log messaging about upcoming Homebridge v2.0.0 update
  - NOTICE TO USERS AND PLUGIN DEVELOPERS
    - Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
    - Please visit the following link to learn more about the changes and how to prepare:
      - [Updating-To-Homebridge-v2.0](https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0)
donavanbecker added a commit that referenced this pull request Jul 19, 2024
@donavanbecker
v1.8.4
95c211d 
- Fix default FirmwareRevision (#3644) (@hjdhjd)

- Detect config interface on registerPlatform (#3609) (@duddu)
- Updated dependencies, fix `typedoc` generation
- Added log messaging about upcoming Homebridge v2.0.0 update
  - NOTICE TO USERS AND PLUGIN DEVELOPERS
    - Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
    - Please visit the following link to learn more about the changes and how to prepare:
      - [Updating-To-Homebridge-v2.0](https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0)

Revert "v1.8.4"

This reverts commit bfd209f.

v1.8.4

- Fix default FirmwareRevision (#3644) (@hjdhjd)

- Detect config interface on registerPlatform (#3609) (@duddu)
- Updated dependencies, fix `typedoc` generation
- Added log messaging about upcoming Homebridge v2.0.0 update
  - NOTICE TO USERS AND PLUGIN DEVELOPERS
    - Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
    - Please visit the following link to learn more about the changes and how to prepare:
      - [Updating-To-Homebridge-v2.0](https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0)
donavanbecker added a commit that referenced this pull request Jul 19, 2024
@donavanbecker
v1.8.4
e313a91 
- Fix default FirmwareRevision (#3644) (@hjdhjd)

- Detect config interface on registerPlatform (#3609) (@duddu)
- Updated dependencies, fix `typedoc` generation
- Added log messaging about upcoming Homebridge v2.0.0 update
  - NOTICE TO USERS AND PLUGIN DEVELOPERS
    - Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
    - Please visit the following link to learn more about the changes and how to prepare:
      - [Updating-To-Homebridge-v2.0](https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0)
donavanbecker added a commit that referenced this pull request Jul 19, 2024
@donavanbecker
v1.8.4
47adf50 
- Fix default FirmwareRevision (#3644) (@hjdhjd)

- Detect config interface on registerPlatform (#3609) (@duddu)
- Updated dependencies, fix `typedoc` generation
- Added log messaging about upcoming Homebridge v2.0.0 update
  - NOTICE TO USERS AND PLUGIN DEVELOPERS
    - Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
    - Please visit the following link to learn more about the changes and how to prepare:
      - [Updating-To-Homebridge-v2.0](https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0)
donavanbecker added a commit that referenced this pull request Jul 19, 2024
@donavanbecker
v1.8.4
9ec7e16 
- Fix default FirmwareRevision (#3644) (@hjdhjd)

- Detect config interface on registerPlatform (#3609) (@duddu)
- Updated dependencies, fix `typedoc` generation
- Added log messaging about upcoming Homebridge v2.0.0 update
  - NOTICE TO USERS AND PLUGIN DEVELOPERS
    - Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
    - Please visit the following link to learn more about the changes and how to prepare:
      - [Updating-To-Homebridge-v2.0](https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0)
donavanbecker added a commit that referenced this pull request Jul 19, 2024
@donavanbecker
v1.8.4
2b47540 
- Fix default FirmwareRevision (#3644) (@hjdhjd)

- Detect config interface on registerPlatform (#3609) (@duddu)
- Updated dependencies, fix `typedoc` generation
- Added log messaging about upcoming Homebridge v2.0.0 update
  - NOTICE TO USERS AND PLUGIN DEVELOPERS
    - Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
    - Please visit the following link to learn more about the changes and how to prepare:
      - [Updating-To-Homebridge-v2](https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2)
donavanbecker added a commit that referenced this pull request Jul 22, 2024
@donavanbecker
v1.8.4
12b5338 
- Fix default FirmwareRevision (#3644) (@hjdhjd)

- Detect config interface on registerPlatform (#3609) (@duddu)
- Updated dependencies, fix `typedoc` generation
- Added log messaging about upcoming Homebridge v2.0.0 update
  - NOTICE TO USERS AND PLUGIN DEVELOPERS
    - Homebridge 2.0 is on the way and brings some breaking changes to existing plugins.
    - Please visit the following link to learn more about the changes and how to prepare:
      - [Updating-To-Homebridge-v2.0](https://github.com/homebridge/homebridge/wiki/Updating-To-Homebridge-v2.0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donavanbecker donavanbecker donavanbecker approved these changes

@bwp91 bwp91 Awaiting requested review from bwp91

Assignees
No one assigned
Labels
fix latest
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hjdhjd @coveralls @donavanbecker