Rancher logging and Release workflow #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* cmd/arcade/arcade.go: Set Flags for logging * internal/rancher/client.go: Add logging when getting token fails * internal/rancher/client_test.go: Added 2 test cases to cover new code paths for logging * build.sh: Add script to build arcade (same process can now be used manually and workflow files) * get-dependencies.sh: Add script to get build dependencies (same process can now be used manually and workflow files) * docker/build.sh → docker/docker-build.sh: Rename to avoid confusion with build.sh and call get-dependencies.sh and build.sh instead of duplicating logic * .github/workflows/go.yml: Updated to call get-dependencies.sh and build.sh instead of duplicating logic * .github/workflows/release.yml: New workflow with version parameter to build docker image
DB45T3
approved these changes
Sep 2, 2022
victor-homedepot
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following changes:
cmd/arcade/arcade.go: Set Flags for logging
internal/rancher/client.go: Add logging when getting token fails
internal/rancher/client_test.go: Added 2 test cases to cover new code paths for logging
build.sh: Add script to build arcade (same process can now be used manually and workflow files)
get-dependencies.sh: Add script to get build dependencies (same process can now be used manually and workflow files)
docker/build.sh → docker/docker-build.sh: Rename to avoid confusion with build.sh and call get-dependencies.sh and build.sh instead of duplicating logic
.github/workflows/go.yml: Updated to call get-dependencies.sh and build.sh instead of duplicating logic
.github/workflows/release.yml: New workflow with version parameter to build docker image