Support pipeline name as param #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billimek
approved these changes
Nov 17, 2022
|
Thanks for your patience. This looked good to me too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Addresses #36
What changes did you make? (Give a brief overview)
Add the capability to specify pipeline name and pipeline instance vars. This allows one pipeline to configure the webhooks for another one, which is useful when using multi-branch workflows, in which one pipeline is responsible for creating and destroying other pipelines.
Without this change there is no easy way for the parent pipeline to set the webhook in Github to trigger the child pipelines, nor to delete that webhook once the child pipeline is removed.
Is there anything specific you would like reviewers to focus on?
No