Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to submit sysvars should return proper HTTP status code #38

Open
TinkyWonky opened this issue Feb 27, 2020 · 0 comments
Open

Failure to submit sysvars should return proper HTTP status code #38

TinkyWonky opened this issue Feb 27, 2020 · 0 comments

Comments

@TinkyWonky
Copy link

Situation
Trying to submit new values for existing system variables using statechange.cgi, the provided parameter string is ill-formatted, like ?ise_foo=42&new_bar=baz.

Current Behaviour
The returned result code is 200 ("OK").

Suggested Behaviour
HTTP status code indicate that something went wrong. Perhaps in detail:

  • Ill-formatted ?ise_id=... and &new_value=... result in code 400 ("Bad Request").
  • Invalid ide_id values (system variable not known) result in code 422 ("Unprocessable Entity "). Maybe 406 ("Not Acceptable") or 416 ("Requested range not satisfiable")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants