Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unauthenticated requests send wrong HTTP status code #82

Closed
klada opened this issue Nov 2, 2023 · 1 comment
Closed

Unauthenticated requests send wrong HTTP status code #82

klada opened this issue Nov 2, 2023 · 1 comment

Comments

@klada
Copy link

klada commented Nov 2, 2023

Starting with version 2.0 the API requires an authentication token. However this is not signaled correctly through a HTTP status code.

Scripts which are accessing the API without a valid token are still getting a HTTP 200 status code (which means OK). However the correct status code would be 403 or 401.

Since the API continues to reply with 200 existing scripts might break without the user noticing as it is a common pattern to check for status codes when processing API requests.

@jens-maus
Copy link
Member

essentially a duplicate of #38

@jens-maus jens-maus closed this as not planned Won't fix, can't repro, duplicate, stale Nov 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants