Merge security fixes of mastodon v4.0.13 (#1340) #93
dariuskAnnotations
7 errors and 3 warnings
|
Lint Code Base:
app/helpers/jsonld_helper.rb#L115
[Correctable] Style/ArrayCoercion: Use Array(compacted_value) instead of explicit Array check.
|
|
Lint Code Base:
app/helpers/jsonld_helper.rb#L146
[Correctable] Style/ClassEqualityComparison: Use instance_of?(compacted_value.class) instead of comparing classes.
|
|
Lint Code Base:
app/helpers/jsonld_helper.rb#L173
Style/OptionalBooleanParameter: Prefer keyword arguments for arguments with a boolean default value; use raise_on_temporary_error: false instead of raise_on_temporary_error = false.
|
|
Lint Code Base:
app/lib/activitypub/activity.rb#L156
[Correctable] Layout/EmptyLines: Extra blank line detected.
|
|
Lint Code Base:
app/models/preview_card_provider.rb#L55
[Correctable] Style/SlicingWithRange: Prefer ary[n..] over ary[n..-1].
|
|
Lint Code Base:
app/services/fetch_resource_service.rb#L21
Style/OptionalBooleanParameter: Prefer keyword arguments for arguments with a boolean default value; use terminal: false instead of terminal = false.
|
|
Lint Code Base:
app/services/fetch_resource_service.rb#L42
Style/OptionalBooleanParameter: Prefer keyword arguments for arguments with a boolean default value; use terminal: false instead of terminal = false.
|
|
Lint Code Base
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-node@v3, r7kamura/rubocop-problem-matchers-action@v1, xt0rted/stylelint-problem-matcher@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
|
Lint Code Base
The following actions uses node12 which is deprecated and will be forced to run on node16: xt0rted/stylelint-problem-matcher@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
Lint Code Base:
app/helpers/jsonld_helper.rb#L116
Lint/NonLocalExitFromIterator: Non-local exit from iterator, without return value. next, break, Array#find, Array#any?, etc. is preferred.
|