Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extended documentation for deep-sleep #579

Merged
merged 1 commit into from
May 10, 2019

Conversation

kleini
Copy link
Collaborator

@kleini kleini commented Mar 10, 2019

In my testcases the provided example for deep-sleep mostly caused the properties of some HomieNodes sent in HomieNode::loop() method not to be received by the MQTT broker. Maybe this is due to new async SSL connection handling of my other pull request #577. The introduced postpone of going into deep sleep solved properly the properties of HomieNodes to be received by the MQTT broker.

Maybe there is a better solution by asking the MQTTclient for its state about sending messages, but I did not find one. If you point me to the right place, I will try to fix this correctly.

@stritti
Copy link
Collaborator

stritti commented Mar 23, 2019

@kleini I think it would be good if you add part of your PR comments also to the docs to describe for new users why it is done that way.

@kleini
Copy link
Collaborator Author

kleini commented Mar 24, 2019

I need to debug once more, what is going on towards deep sleep and why are MQTT messages are not properly sent if I use the original example code.

@kleini kleini force-pushed the docs_deep_sleep branch 2 times, most recently from 503875e to 8c15e35 Compare March 24, 2019 20:14
@kleini
Copy link
Collaborator Author

kleini commented Mar 24, 2019

The documentation is improved. But my gut feeling tells me, that a new event is necessary providing information about a successful processing of the loop() method of all HomieNodes. But this can be another merge request.

@stritti stritti requested a review from euphi March 30, 2019 23:08
@MoJo2600
Copy link

MoJo2600 commented May 8, 2019

Shouldn't it be Homie.doDeepSleep() instead of ESP.deepSleep()? The Homie method is not doing much currently, but I think there is a purpose for having a framework method to do deep sleeping.

@kleini
Copy link
Collaborator Author

kleini commented May 8, 2019

@MoJo2600 you're right. I did not change that sentence and did not even notice, that it is wrong.

@kleini kleini force-pushed the docs_deep_sleep branch 2 times, most recently from a1ab7ef to 4f27a0f Compare May 9, 2019 20:35
@kleini
Copy link
Collaborator Author

kleini commented May 9, 2019

Fixed and ready to be merged.

@MoJo2600
Copy link

The code is working perfectly. I already implemented it in one of my homie devices. Thank you. I found a typo and left a comment.

@stritti
Copy link
Collaborator

stritti commented May 10, 2019

one question: merge into develop or develop-v3? Or both ...

@kleini
Copy link
Collaborator Author

kleini commented May 10, 2019

one question: merge into develop or develop-v3? Or both ...

This documentation is relevant for both.

@stritti stritti merged commit 1c500f4 into homieiot:develop May 10, 2019
stritti pushed a commit that referenced this pull request May 10, 2019
@stritti
Copy link
Collaborator

stritti commented May 10, 2019

Merged to develop and develop-v3

@kleini kleini deleted the docs_deep_sleep branch September 25, 2019 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants