-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extended documentation for deep-sleep #579
Conversation
@kleini I think it would be good if you add part of your PR comments also to the docs to describe for new users why it is done that way. |
I need to debug once more, what is going on towards deep sleep and why are MQTT messages are not properly sent if I use the original example code. |
503875e
to
8c15e35
Compare
The documentation is improved. But my gut feeling tells me, that a new event is necessary providing information about a successful processing of the loop() method of all HomieNodes. But this can be another merge request. |
Shouldn't it be |
@MoJo2600 you're right. I did not change that sentence and did not even notice, that it is wrong. |
a1ab7ef
to
4f27a0f
Compare
Fixed and ready to be merged. |
The code is working perfectly. I already implemented it in one of my homie devices. Thank you. I found a typo and left a comment. |
one question: merge into |
This documentation is relevant for both. |
Merged to |
In my testcases the provided example for deep-sleep mostly caused the properties of some HomieNodes sent in HomieNode::loop() method not to be received by the MQTT broker. Maybe this is due to new async SSL connection handling of my other pull request #577. The introduced postpone of going into deep sleep solved properly the properties of HomieNodes to be received by the MQTT broker.
Maybe there is a better solution by asking the MQTTclient for its state about sending messages, but I did not find one. If you point me to the right place, I will try to fix this correctly.