Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed wrong WiFi DNS parsing of commit 2093ce8665366ce056d5ee5894e52c… #646

Merged
merged 1 commit into from
Dec 15, 2019
Merged

fixed wrong WiFi DNS parsing of commit 2093ce8665366ce056d5ee5894e52c… #646

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Homie/Utils/Validation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ ConfigValidationResult Validation::_validateConfigWifi(const JsonObject object)
JsonVariant wifiDns2 = wifi["dns2"];

if (!wifiDns1.isNull()) {
if (wifiDns1.as<const char*>()) {
if (!wifiDns1.as<const char*>()) {
result.reason = F("wifi.dns1 is not a string");
return result;
}
Expand All @@ -204,7 +204,7 @@ ConfigValidationResult Validation::_validateConfigWifi(const JsonObject object)
}
}
if (!wifiDns2.isNull()) {
if (wifiDns2.as<const char*>()) {
if (!wifiDns2.as<const char*>()) {
result.reason = F("wifi.dns2 is not a string");
return result;
}
Expand Down