Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatic Settings #17

Open
jcblw opened this issue Sep 24, 2014 · 8 comments
Open

Automatic Settings #17

jcblw opened this issue Sep 24, 2014 · 8 comments

Comments

@jcblw
Copy link
Contributor

jcblw commented Sep 24, 2014

We should start using this as the main embed script, I think it gives us alot more leverage to do things on peoples pages. I would say that it is a pain to have to write any JavaScript to get things like auto resize to work. I feel that should work right out of the box by just embedding the script. I dont think it makes sense to have the init function dictate this. I mean I even thought it was a bug.

@jcblw
Copy link
Contributor Author

jcblw commented Sep 30, 2014

@honeinc/developers I do think this what is holding us back from more integration with our script.

@gohone
Copy link

gohone commented Sep 30, 2014

I don't think anyone is integrating this for two reasons:

  1. They are used to iframes.
  2. We haven't pushed this because it doesn't offer that many advantages.

I think the sentiment of the ticket is correct that just including this
script should make things just work without calling init. I just don't
think that's the reason people aren't using this.

If we spend a bit more time on this, I think we could start pushing it as
our main way to embed (for instance, changing the embed code generation to
be a script tag with this scripts, etc).

On Monday, September 29, 2014, Jacob Lowe notifications@github.com wrote:

@honeinc/developers https://github.com/orgs/honeinc/teams/developers I
do think this what is holding us back from more integration with our script.


Reply to this email directly or view it on GitHub
#17 (comment).

@jcblw
Copy link
Contributor Author

jcblw commented Sep 30, 2014

I would say number 2 is probably the primary reason. There is not many embed that are purely iframes anymore beside youtube, vemio, or another video sharing service. Most of the interactive embeddable content nowadays has script companions with html.

Facebook Comments
screenshot from 2014-09-30 15 24 14
Embed a Tweet
screenshot from 2014-09-30 15 23 24
http://embed.ly/ site all about embeds
screenshot from 2014-09-30 15 20 35
Qzzr
screenshot from 2014-09-30 15 12 28
Disqus
screenshot from 2014-09-30 15 11 05

@AlecEmmons
Copy link

I'm for it, sounds tight!

We should get a quick documentation page together or at least I can compile
and throw onto a page on our wordpress site with some basic parameters or
something...support is always helpful right?

On Tue, Sep 30, 2014 at 3:34 PM, Jacob Lowe notifications@github.com
wrote:

I would say number 2 is probably the primary reason. There is not many
embed that are purely iframes anymore beside youtube, vemio, or another
video sharing service. Most of the interactive embeddable content nowadays
has script companions with html.

Facebook Comments
[image: screenshot from 2014-09-30 15 24 14]
https://cloud.githubusercontent.com/assets/578259/4467525/5b53aec8-48f1-11e4-817a-518e88ab7522.png
Embed a Tweet
[image: screenshot from 2014-09-30 15 23 24]
https://cloud.githubusercontent.com/assets/578259/4467532/6cc305be-48f1-11e4-9c2f-e73c43b4a6ab.png
http://embed.ly/ site all about embeds
[image: screenshot from 2014-09-30 15 20 35]
https://cloud.githubusercontent.com/assets/578259/4467533/6cc5a3c8-48f1-11e4-9a32-5129da7fa37a.png
Qzzr
[image: screenshot from 2014-09-30 15 12 28]
https://cloud.githubusercontent.com/assets/578259/4467534/6cc8e7a4-48f1-11e4-81ff-6da98b573610.png
Disqus
[image: screenshot from 2014-09-30 15 11 05]
https://cloud.githubusercontent.com/assets/578259/4467535/6cc9db0a-48f1-11e4-968d-720d8d4bb1a3.png


Reply to this email directly or view it on GitHub
#17 (comment).

Alec Emmons
Creative Director /// General Partner
Soekan Design, LLC
alec@soekan.com
605-222-9640
aim: Johnny7686

@jcblw
Copy link
Contributor Author

jcblw commented Sep 30, 2014

Yeah, Im all for this it. may mean we should take a quick pass at testing it in a number of browsers I can do that and even write some simple test for it just so we do not break anyone's site.

@AlecEmmons support it helpful.

@AlecEmmons
Copy link

wordddddddddddawwwwggggg

On Tue, Sep 30, 2014 at 4:14 PM, Jacob Lowe notifications@github.com
wrote:

Yeah, Im all for this it. may mean we should take a quick pass at testing
it in a number of browsers I can do that and even write some simple test
for it just so we do not break anyone's site.

@AlecEmmons https://github.com/AlecEmmons support it helpful.


Reply to this email directly or view it on GitHub
#17 (comment).

Alec Emmons
Creative Director /// General Partner
Soekan Design, LLC
alec@soekan.com
605-222-9640
aim: Johnny7686

@jcblw
Copy link
Contributor Author

jcblw commented Oct 1, 2014

look like everything works just fine on IE9, latest Firefox, latest Safari, and Chrome.

@jcblw
Copy link
Contributor Author

jcblw commented Oct 1, 2014

also IE 8 fails gracefully not erroring.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants