-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatic Settings #17
Comments
@honeinc/developers I do think this what is holding us back from more integration with our script. |
I don't think anyone is integrating this for two reasons:
I think the sentiment of the ticket is correct that just including this If we spend a bit more time on this, I think we could start pushing it as On Monday, September 29, 2014, Jacob Lowe notifications@github.com wrote:
|
I would say number 2 is probably the primary reason. There is not many embed that are purely iframes anymore beside youtube, vemio, or another video sharing service. Most of the interactive embeddable content nowadays has script companions with html. Facebook Comments |
I'm for it, sounds tight! We should get a quick documentation page together or at least I can compile On Tue, Sep 30, 2014 at 3:34 PM, Jacob Lowe notifications@github.com
Alec Emmons |
Yeah, Im all for this it. may mean we should take a quick pass at testing it in a number of browsers I can do that and even write some simple test for it just so we do not break anyone's site. @AlecEmmons support it helpful. |
wordddddddddddawwwwggggg On Tue, Sep 30, 2014 at 4:14 PM, Jacob Lowe notifications@github.com
Alec Emmons |
look like everything works just fine on IE9, latest Firefox, latest Safari, and Chrome. |
also IE 8 fails gracefully not erroring. |
We should start using this as the main embed script, I think it gives us alot more leverage to do things on peoples pages. I would say that it is a pain to have to write any JavaScript to get things like auto resize to work. I feel that should work right out of the box by just embedding the script. I dont think it makes sense to have the init function dictate this. I mean I even thought it was a bug.
The text was updated successfully, but these errors were encountered: