Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Use subreddit style" incompatible with APNG 2.1.2 Chrome extension #1076

Closed
ghost opened this issue May 15, 2014 · 3 comments
Closed

"Use subreddit style" incompatible with APNG 2.1.2 Chrome extension #1076

ghost opened this issue May 15, 2014 · 3 comments

Comments

@ghost
Copy link

ghost commented May 15, 2014

E.g. I go to a subreddit, uncheck it and nothing happens. The style is disabled after page reload, but on the next reload it's back to enabled while the checkbox is unchecked.

srstyle off does not work for me, too.

Chrome Version 34.0.1847.131 m / APNG 2.1.2

I use this one: https://chrome.google.com/webstore/detail/apng/ehkepjiconegkhpodgoaeamnpckdbblp

@jewel-andraia
Copy link
Collaborator

http://www.reddit.com/r/RESissues/comments/1yvgrl/bug_res_has_problems_with_another_chrome/

I don't think there's much RES can do about it, sorry.

edit: maybe we can submit a PR to https://github.com/davidmz/apng-chrome with some fix?

@davidmz
Copy link

davidmz commented May 16, 2014

Hi, I'm the author of apng-chrome. I would like to help, but unfortunately I don't know what exactly doing RES.

That's what apng-chrome doing on Reddit after the page loads:

  1. Looks for linked styles from *.thumbs.redditmedia.com domains
  2. Downloads them and inserts into the page using STYLE tags
  3. Replaces the style's APNG images to animated canvases
  4. Removes links to external styles

All this is done because the styles from other domains are not available from within a document, so I have to embed them in the document itself.

At what point this algorithm can interfere with RES?

@matheod
Copy link
Collaborator

matheod commented May 16, 2014

I suppose (I didn't checked) RES remove the when disabling the custom subreddit css. But as you transform the link into style, RES will not remove it. As your style have a "data-apng-original-href" attribute, I think RES can handle this. I will try to solve this problem.

matheod added a commit that referenced this issue May 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants