Show subscription on reddit #1031
Conversation
Allow to see number of new comments, etc.
| var url = ''; | ||
| var threads = $("#newCommentsTable tr"); // use the table to keep the selected sorting | ||
| for(var i = 1, len = threads.length; i < len; i++) { // i = 1 to avoid the table header | ||
| url += ',t3_' + $(threads[i]).find('td:first span[thread]').attr('thread'); |
There was a problem hiding this comment.
why not use RES's data directly? this is the dashboard, RES creates all the DOM itself.
There was a problem hiding this comment.
To allow people to sort by clicking on header of the table, then opening link in the sorted way choosen.
There was a problem hiding this comment.
i suppose that's an okay reason.
I still have some nitpicks with that for loop, but it's just style-- not mission-critical
There was a problem hiding this comment.
Yea true, now it's better.
Replace this horrible for for a pretty each
| @@ -58,6 +58,16 @@ modules['newCommentCount'] = { | |||
| var showDiv = $('<div class="show">Show:</div>') | |||
| var subscriptionFilter = $('<select id="subscriptionFilter"><option>subscribed threads</option><option>all threads</option></select>') | |||
| $(showDiv).append(subscriptionFilter); | |||
| var openOnReddit = $('<div class="addButton" id="openOnReddit">Open on Reddit</div>'); | |||
| $(openOnReddit).click(function() { | |||
There was a problem hiding this comment.
This can simply be openOnReddit.click since openOnReddit is already a jQuery object: ideally, you should rename it to $openOnReddit so it's clear that it is a jQuery object. Same with the showDiv variable above.
There was a problem hiding this comment.
I used the same notation than above in the code (I.e. showDiv for exemple).
Thanks mc10
Thanks andytuba
Show subscription on reddit
See #1027.