Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference reddit preference for subreddit style in settings console #1094

Merged
merged 2 commits into from
May 18, 2014
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Reference reddit preference for subreddit style in settings console fix
  • Loading branch information
matheod committed May 17, 2014
commit 84977120bd99cdbf5b5a9d99f22f4a289bdd466d
2 changes: 1 addition & 1 deletion lib/modules/styleTweaks.js
Original file line number Diff line number Diff line change
@@ -2,7 +2,7 @@ modules['styleTweaks'] = {
moduleID: 'styleTweaks',
moduleName: 'Style Tweaks',
category: 'UI',
description: 'Provides a number of style tweaks to the Reddit interface',
description: 'Provides a number of style tweaks to the Reddit interface. Also allow you to disable specific subreddit style (the <a href="/prefs/#show_stylesheets">global setting</a> must be on).',
options: {
navTop: {
type: 'boolean',
3 changes: 3 additions & 0 deletions lib/res.css
Original file line number Diff line number Diff line change
@@ -1262,6 +1262,9 @@ a.bylink.parentlink {
.md .usertext-body img {
display: inherit;
}
#show_stylesheets:target + label {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure how i feel about always highlighting the "use subreddit style" preference.

How about instead additionally adding a little blurb after the label "RES allows you to disable specific subreddit styles! Click here to learn more"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not always, it's on target.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah okay 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like that ?

background-color: lightblue;
}
/* Compiled SCSS from MediaCrush - https://github.com/MediaCrush/MediaCrush */
.player {
position: relative; }