Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

voteEnhancement post score color option #1313

Closed
wants to merge 5 commits into from
Closed

voteEnhancement post score color option #1313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c98e51b
Option to choose coloration type
matheod Jun 24, 2014
88664fd
Add userDefinedLinkColoration option
matheod Jun 24, 2014
ece1997
Fix for color input in table option
matheod Jun 24, 2014
e8133f9
Add default value to test
matheod Jun 24, 2014
8f87f03
Final implementation
matheod Jun 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 45 additions & 4 deletions lib/modules/voteEnhancements.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,38 @@ modules['voteEnhancements'] = {
description: 'Makes post/comment scores bold and therefore easier to find.'
},
colorLinkScore: {
type: 'boolean',
value: false,
type: 'enum',
values: [{
name: 'No coloration',
value: 'none'
}, {
name: 'Automatic coloration',
value: 'automatic'
}, {
name: 'User Defined coloration',
value: 'user'
}],
value: 'none',
description: 'Add color to link\'s score depending on its value. (Does not work with "compressed link display" reddit preference)'
},
userDefinedLinkColoration: {
type: 'table',
addRowText: '+add threshold',
fields: [{
name: 'score',
type: 'text'
}, {
name: 'color',
type: 'color',
}],
value: [
['0', '#5f99cf'],
['10', '#F2B035'],
['50', '#FF4500'],
['100', '#D92B2B']
],
description: 'Choose color for colorLinkScore with threshold of your choice.'
},
colorCommentScore: {
type: 'boolean',
value: false,
Expand All @@ -49,7 +77,7 @@ modules['voteEnhancements'] = {
this.estimatePostScoreVotes();
}
}
if (this.options.colorLinkScore.value) {
if (this.options.colorLinkScore.value !== 'none') {
RESUtils.addCSS('.link .rank { color: #fff; text-align: center; border-radius: 1em; font-size: 12px; padding: 4px; line-height: 1; height: 1em; min-width: 1em; }');
this.applyLinkScoreColor();
RESUtils.watchForElement('siteTable', modules['voteEnhancements'].applyLinkScoreColor);
Expand Down Expand Up @@ -83,6 +111,19 @@ modules['voteEnhancements'] = {
}
}
},
getLinkScoreColor: function(score) {
if (this.options.colorLinkScore.value === 'automatic') {
return 'hsl(' + 180+360*(1-100/(150+score)) + ', 75%,50%)';
} else {
if (this.options.userDefinedLinkColoration.value.length) {
for (var len = this.options.userDefinedLinkColoration.value.length, i = len-1; i >= 0; i--) {
if (score >= this.options.userDefinedLinkColoration.value[i][0]) {
return this.options.userDefinedLinkColoration.value[i][1];
}
}
}
}
},
highlightScores: function() {
RESUtils.addCSS('span.score { font-weight: bold; color: #333; }');
},
Expand All @@ -92,7 +133,7 @@ modules['voteEnhancements'] = {
for (var i = 0, len = scoreNode.length; i < len; i++) {
var node = scoreNode[i];
if (!isNaN(parseInt(node.innerText), 10)) {
$(node).closest('.thing').find('.rank')[0].style.background = 'hsl(' + 180+360*(1-100/(150+parseInt(node.innerText, 10))) + ', 75%,50%)';
$(node).closest('.thing').find('.rank')[0].style.background = this.getLinkScoreColor(parseInt(node.innerText, 10));
} else {
$(node).closest('.thing').find('.rank')[0].style.background = '#c6c6c6';
}
Expand Down
4 changes: 3 additions & 1 deletion lib/res.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -554,10 +554,12 @@ p.moduleListing {
float: left;
width: 140px;
}
.optionContainer input[type=color] {
.optionContainer>input[type=color] {
margin-left: 10px;
margin-top: -3px;
float: left;
}
.optionContainer input[type=color] {
width: 56px;
height: 20px;
}
Expand Down