update modules.bitcoinTip with skeeto's refactoring, my refactoring, and my fixups #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
we still need to put in that options button to call fetchAddresses. |
honestbleeps, is there a reason you chose value before? it seems inappropriate for the button text to be the option value
any reason why !important?
…for bitcoin wallet
|
FYI I touched some global CSS and RESUtils. |
honestbleeps
added a commit
that referenced
this pull request
Apr 5, 2013
update modules.bitcoinTip with skeeto's refactoring, my refactoring, and my fixups
patricksnape
pushed a commit
to patricksnape/Reddit-Enhancement-Suite
that referenced
this pull request
Jun 23, 2013
update modules.bitcoinTip with skeeto's refactoring, my refactoring, and my fixups
honestbleeps
added a commit
that referenced
this pull request
Sep 2, 2013
update modules.bitcoinTip with skeeto's refactoring, my refactoring, and my fixups
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I worked my way through skeeto's bitcoinTip and updated RES's copy of the bitcoinTip module with it, refactored a little more, then added in more RES functionality like watchForElements('newComments', ...) and forEachChunked
For more details see:
skeeto/bitcointip-user-js@res-module-plus
skeeto/bitcointip-user-js@4ae03fd
It probably deserves another regression test 😒