Always update Comment Navigator's # comments #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Navigator didn't update correctly in some case
|
I'm confused by this PR. why not reset the navigator anymore? |
|
I reset it just after : https://github.com/honestbleeps/Reddit-Enhancement-Suite/pull/995/files#diff-8dd4ef296489e23f27a2ca803a5788c4R270 The problem was the reset was in the if block, which is executed only at the first time we select the category. |
honestbleeps
added a commit
that referenced
this pull request
May 6, 2014
Closed
jewel-andraia
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigator didn't update correctly in some case