fix(plugin-core): support minified url creation with pathname in assetUrl #1248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subzero10
reviewed
Nov 16, 2023
| @@ -81,7 +82,9 @@ export async function buildBodyForSourcemapUpload( | |||
| ): Promise<FormData> { | |||
| const form = new FormData() | |||
|
|
|||
| const minifiedUrl = new URL(sourcemapData.jsFilename, hbOptions.assetsUrl).href | |||
| const url = new URL(hbOptions.assetsUrl) | |||
There was a problem hiding this comment.
This is strange, the second parameter of URL() constructor is the baseUrl, so it shouldn't be replacing it.
I will test this on a nextjs project as well.
There was a problem hiding this comment.
I confirm that the second parameter of the URL constructor will strip out any pathnames in the string.
subzero10
changed the title
subzero10
approved these changes
Nov 23, 2023
| @@ -81,7 +82,9 @@ export async function buildBodyForSourcemapUpload( | |||
| ): Promise<FormData> { | |||
| const form = new FormData() | |||
|
|
|||
| const minifiedUrl = new URL(sourcemapData.jsFilename, hbOptions.assetsUrl).href | |||
| const url = new URL(hbOptions.assetsUrl) | |||
There was a problem hiding this comment.
I confirm that the second parameter of the URL constructor will strip out any pathnames in the string.
|
This should be fixed with @honeybadger-io/nextjs@5.8.4! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Description
honeybadger-io/nextsuggest to set the assetUrl tohttps://my-app.vercel.app/_next(link)However, the plugin-core uses the
URLclass in a way that does not support this. Instead of overwriting the assetsUrl pathname, this PR joins them.Steps to Test or Reproduce
_nextin the pathname