chore: added ESM support

[subzero10]

Status

READY

Description

Fixes #823.

[subzero10]

Integration tests are failing. Looking into it.

[BethanyBerkowitz]

@subzero10 what will happen if someone is using this package in an esm module in Node? Will they potentially end up with the browser version instead of the server version?

[subzero10]

@subzero10 what will happen if someone is using this package in an esm module in Node? Will they potentially end up with the browser version instead of the server version?

I had the same question my self. It's very confusing to say the least:

• esbuild says here that nodejs does not support the "module" field. nodejs does not mention the "module" in their docs either.
• esbuild has a recommended section for package authors. So I went ahead and applied this. I tested with webpack. Apparently, webpack will always import the esm build, even if require is used (as in our example project). This broke the bundle, though I was able to fix it by changing the require to an import statement, or forcing webpack to resolve the cjs build.

That's why I opted for the simplest non-breaking change, even though it's recommended to avoid 🤷 .
Once again, having the package isomorphic makes things more complicated than they should. I am hoping that soon we'll be able to break the js package to separate packages for node vs browser.

[joshuap]

@subzero10 can we close this issue since it’s stale or do you want to keep it open?

[subzero10]

I'm closing and we can revisit if we receive new requests for ESM support.