change: change log level of init message to DEBUG #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subzero10
reviewed
Oct 19, 2023
.gitignore
Outdated
| @@ -7,3 +7,4 @@ Gemfile.lock | |||
| .rbenv-vars | |||
| java.hprof.txt | |||
| .yardoc | |||
| .tool-versions | |||
There was a problem hiding this comment.
Is this file supposed to be git-ignored?
There was a problem hiding this comment.
Good question. At least I now think that this change shouldn't be part of the PR.
The project doesn't seem to have any ruby default version configurations (like .ruby-version etc.) and so I thought adding a .tool-versions (the equivalent for asdf.vm) would probably not be welcomed.
I will at least remove that change from this PR.
There was a problem hiding this comment.
OK, thanks.
Btw, I'm not against the idea of ignoring the file, just wanted to know if there's a preferred way of handling versions.
subzero10
approved these changes
Oct 23, 2023
This was referenced Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #447 this is the preferred solution: Simply make the init message a DEBUG level message
Fixes #447