Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mongodb instrumentation promises doesn't seem to propagate results / errors #89

Closed
omfgitsjack opened this issue Oct 15, 2018 · 0 comments · Fixed by #107
Closed

mongodb instrumentation promises doesn't seem to propagate results / errors #89

omfgitsjack opened this issue Oct 15, 2018 · 0 comments · Fixed by #107

Comments

@omfgitsjack
Copy link

There appears to be an issue with the mongodb instrumentation where promises don't return any value. This means any promise payloads & errors get swallowed
@geekflyer geekflyer mentioned this issue Jan 6, 2019
Merged
toshok added a commit that referenced this issue Jan 7, 2019
@toshok
Merge pull request #107 from geekflyer/master
dc60846 
The current mongodb instrumentation breaks applications which use any collection method which returns a Promise.

This MR fixes that by:
1. properly `return`ing the promise in all places
2. return the original promise (rv) and add instrumentation on a seperate promise chain

Besides a few other things this MR also fixes #89
@pvatterott pvatterott mentioned this issue Oct 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix mongodb instrumentation when using Promises
1 participant
@omfgitsjack