add rollup SQL duration time to Django traces #207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmhodges-color
force-pushed
the
dbduration
branch
from
e2ddb25 to
19ca1c5
Compare
Out of honeycombio#205 (and internal conversation at my org), adding a rollup field that includes how much time was spent executing SQL queries was also desirable for an out-of-the-box experience. This adds that field. There was a name collision with the already existing `db.duration` here and the similarly named variable in the Go beeline that is used for total time, so we choose the `db.total_duration` name here.
jmhodges-color
force-pushed
the
dbduration
branch
from
19ca1c5 to
a7c2e42
Compare
vreynolds
approved these changes
Jan 25, 2022
vreynolds
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of #205 (and internal conversation at my org), adding a rollup field
that includes how much time was spent executing SQL queries was also
desirable for an out-of-the-box experience. This adds that field.
There was a name collision with the already existing
db.durationhereand the similarly named variable in the Go beeline that is used for
total time, so we choose the
db.total_durationname here.