Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop unnecessary backwards compatibility (remove six) #228

Merged
merged 1 commit into from
Jul 15, 2022

Conversation

robbkidd
Copy link
Member

@robbkidd robbkidd commented Jul 15, 2022

Beeline hasn't supported use under Python 2 for a while now, so we can remove compat code.

Which problem is this PR solving?

Short description of the changes

  • Removes uses of six

cleaning up

Note: six is still a transitive dep via dev dependencies, so it still appears in the poetry.lock.

» poetry show --tree
mock 3.0.5 Rolling backport of unittest.mock for all Pythons
└── six *
pylint 2.6.2 python code static checker
└── astroid >=2.4.0,<2.5
    └── six >=1.12,<2.0

Beeline hasn't supported use under Python 2 for a while now, so we can
remove compat code.

Note: six is still a transitive dep via dev dependencies, so it still
appears in the poetry.lock.

    » poetry show --tree
    mock 3.0.5 Rolling backport of unittest.mock for all Pythons
    └── six *
    pylint 2.6.2 python code static checker
    └── astroid >=2.4.0,<2.5
        └── six >=1.12,<2.0
@robbkidd robbkidd requested a review from a team July 15, 2022 19:59
Copy link
Contributor

@vreynolds vreynolds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 ✨

@robbkidd robbkidd merged commit 3803e11 into main Jul 15, 2022
@robbkidd robbkidd deleted the robb.eighty-six-the-use-of-six branch July 15, 2022 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing transitive dependency from libhoney (six)
2 participants