Use dict get instead of direct dict access in Flask init #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maplebed
reviewed
Sep 19, 2018
beeline/middleware/flask/__init__.py
Outdated
| "request.query": environ['QUERY_STRING'] | ||
| "request.user_agent": environ.get('HTTP_USER_AGENT', ''), | ||
| "request.scheme": environ.get('wsgi.url_scheme', ''), | ||
| "request.query": environ.get('QUERY_STRING', '') |
There was a problem hiding this comment.
How about using None instead of the empty string if those fields don't exist?
nathanleclaire
force-pushed
the
nathanleclaire.use_dict_get
branch
from
b6e6e87 to
7b8c50d
Compare
maplebed
reviewed
Sep 19, 2018
asdvalenzuela
approved these changes
Sep 19, 2018
beeline/middleware/flask/__init__.py
Outdated
| @@ -26,17 +26,17 @@ def __init__(self, app): | |||
| self.app = app | |||
|
|
|||
| def __call__(self, environ, start_response): | |||
| trace_name = "flask_http_%s" % environ['REQUEST_METHOD'].lower() | |||
| trace_name = "flask_http_%s" % environ.get('REQUEST_METHOD', None).lower() | |||
tredman
reviewed
Sep 19, 2018
beeline/middleware/flask/__init__.py
Outdated
| @@ -26,17 +26,17 @@ def __init__(self, app): | |||
| self.app = app | |||
|
|
|||
| def __call__(self, environ, start_response): | |||
| trace_name = "flask_http_%s" % environ['REQUEST_METHOD'].lower() | |||
| trace_name = "flask_http_%s" % environ.get('REQUEST_METHOD', None).lower() | |||
There was a problem hiding this comment.
.lower() will raise an exception if the value is None - maybe default to 'unknown_method'?
nathanleclaire
force-pushed
the
nathanleclaire.use_dict_get
branch
from
7b8c50d to
a32e95b
Compare
|
Closes #22 |
nathanleclaire
force-pushed
the
nathanleclaire.use_dict_get
branch
from
a32e95b to
76e4ae0
Compare
maplebed
approved these changes
Sep 19, 2018
|
@nathanleclaire also need to update version in |
nathanleclaire
force-pushed
the
nathanleclaire.use_dict_get
branch
from
76e4ae0 to
7a29757
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still need to understand why the value wasn't present as expected and how to work around that, but this will at least give empty strings instead of rendering the Beeline unusable.