Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Parse version number for beeline-python/{VERSION} addition #257

Merged
merged 1 commit into from
Jan 18, 2023
Merged

fix: Parse version number for beeline-python/{VERSION} addition #257

merged 1 commit into from
Jan 18, 2023

Conversation

emilyashley
Copy link
Contributor

Which problem is this PR solving?

  • Addresses internal bug that shows "beeline-python/{VERSION}" in the user agent rather than the parsed version number.

Short description of the changes

@emilyashley emilyashley requested a review from a team January 18, 2023 16:27
@emilyashley emilyashley added type: bug Something isn't working merge at will Reviewer can merge the PR once reviewed. labels Jan 18, 2023
@emilyashley emilyashley changed the title Parse version number for beeline-python/{VERSION} addition fix: Parse version number for beeline-python/{VERSION} addition Jan 18, 2023
@MikeGoldsmith MikeGoldsmith merged commit cd3bf3f into main Jan 18, 2023
@MikeGoldsmith MikeGoldsmith deleted the emash-fix-user-agent-addition branch January 18, 2023 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees
No one assigned
Labels
merge at will Reviewer can merge the PR once reviewed. type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@emilyashley @MikeGoldsmith