Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add django example #282

Merged
merged 6 commits into from
May 25, 2023
Merged

docs: add django example #282

merged 6 commits into from
May 25, 2023

Conversation

JamieDanielson
Copy link
Contributor

Which problem is this PR solving?

  • Lack of django example; while the repo is maintenance mode and we are focusing efforts on OpenTelemetry, it is still helpful to have examples

Short description of the changes

  • Add django example app
  • Remove poetry.lock files for example apps
  • Make examples more consistent, including trace context and details on beeline.init()
  • Also update the dataset for classic users to match service name, as they should be the same

@JamieDanielson JamieDanielson requested a review from a team May 25, 2023 18:26
@JamieDanielson JamieDanielson self-assigned this May 25, 2023
@JamieDanielson JamieDanielson added type: documentation version: no bump A PR with maintenance or doc changes that aren't included in a release. labels May 25, 2023
@JamieDanielson JamieDanielson merged commit b1db273 into main May 25, 2023
@JamieDanielson JamieDanielson deleted the jamie.django-example branch May 25, 2023 18:48
@JamieDanielson JamieDanielson added the type: maintenance The necessary chores to keep the dust off. label May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees

@JamieDanielson JamieDanielson

Labels
type: documentation type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JamieDanielson @MikeGoldsmith