feat: return list of failed jobs in cmd watch #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TylerHelmuth
added
the
status: oncall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This only applies to buildevents used in CircleCI.
In Honeycomb, we can query against the
watchstep of the buildevents trace to find out how often jobs are failing. Unfortunately, this does not include the list of the failed jobs, reducing its effectiveness, as usually if you are looking at the amount of failed jobs you'd also like to know which jobs failed.As an example of reduced effectiveness, this prevents BubbleUp from showing which jobs are responsible for a failing SLO on % succesful builds.
Short description of the changes
We have the list of failed jobs available to us when we call the circleCI API to find out if there are any failed jobs. This PR wires through a list of names of those failed jobs back through the responses so we can include it as a span attribute in the
watchevent.How to verify that this has the expected result
If we can test with this branch somehow, we should be able to see the result in instrumentation. Let me know if you have ideas.