Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add F# example? ( ･ω･) #296

Merged
merged 8 commits into from
Oct 18, 2022
Merged

Add F# example? ( ･ω･) #296

merged 8 commits into from
Oct 18, 2022

Conversation

cartermp
Copy link
Member

@cartermp cartermp commented Oct 9, 2022 •
edited
Loading

Uses the most popular web framework for F# these days, Giraffe

@cartermp cartermp requested review from a team and pkanal October 9, 2022 19:36
@cartermp cartermp mentioned this pull request Oct 10, 2022
Closed
pkanal
pkanal reviewed Oct 12, 2022
View reviewed changes
Copy link
Contributor

@pkanal pkanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this looks great, thanks for adding it! I left a couple of small comments. Could you also add a README.md file similar to the other examples with instructions on how to run this?

examples/aspnetcore-fsharp/appsettings.json Show resolved Hide resolved
@cartermp
Copy link
Member Author

@pkanal this should be good for final review

@cartermp cartermp added the version: no bump A PR with maintenance or doc changes that aren't included in a release. label Oct 14, 2022
pkanal
pkanal approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@pkanal pkanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

MikeGoldsmith
MikeGoldsmith approved these changes Oct 18, 2022
View reviewed changes
Copy link
Contributor

@MikeGoldsmith MikeGoldsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - the failing workflow step is applying labels that already existed so can be ignored.

@MikeGoldsmith MikeGoldsmith merged commit fbe5408 into main Oct 18, 2022
@MikeGoldsmith MikeGoldsmith deleted the cartermp/fsharp-example branch October 18, 2022 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkanal pkanal pkanal approved these changes

@MikeGoldsmith MikeGoldsmith MikeGoldsmith approved these changes

Assignees
No one assigned
Labels
version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cartermp @MikeGoldsmith @pkanal