Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.github.johnrengelman.shadow from 7.1.0 to 7.1.1 #231

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 17, 2021

Bumps com.github.johnrengelman.shadow from 7.1.0 to 7.1.1.

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps com.github.johnrengelman.shadow from 7.1.0 to 7.1.1.

---
updated-dependencies:
- dependency-name: com.github.johnrengelman.shadow
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team December 17, 2021 22:05
@vreynolds vreynolds added type: security Security issues/fixes. and removed type: dependencies labels Dec 20, 2021
@robbkidd
Copy link
Member

This is an Abundance of Caution™ update.

This dependency has a dependency on log4j. This dependency is a gradle plugin we use to construct a shadowed uber-jar (the resultant JAR includes some dependencies, in our case, upstream OpenTelemetry Java). It is only used in our artifact build pipeline. Our artifact build pipeline does not accept or process any user-input from the internet at large. Neither this dependency nor log4j itself appears in the Honeycomb OTel distribution JARs.

Copy link
Member

@robbkidd robbkidd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

scary shadow, not so scary

@robbkidd robbkidd merged commit 88ea500 into main Dec 21, 2021
@robbkidd robbkidd deleted the dependabot/gradle/com.github.johnrengelman.shadow-7.1.1 branch December 21, 2021 18:53
@robbkidd robbkidd added type: dependencies version: bump patch A PR with release-worthy changes and is backwards-compatible. version: no bump A PR with maintenance or doc changes that aren't included in a release. and removed type: security Security issues/fixes. version: bump patch A PR with release-worthy changes and is backwards-compatible. labels Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependencies version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants