Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: 🔧 add unit test setup #20

Merged
merged 2 commits into from
Jan 3, 2024
Merged

chore: 🔧 add unit test setup #20

merged 2 commits into from
Jan 3, 2024

Conversation

pkanal
Copy link
Contributor

@pkanal pkanal commented Jan 3, 2024 •
edited
Loading

Which problem is this PR solving?

  • Getting the repo ready with basic testing and linting, will be closely followed up by a PR to connect this to CI to run on every PR and the main branch.
  • Closes [maint] Add unit tests #15

Short description of the changes

  • Setup jest testing for unit tests
  • Add lint commands to package.json and fix lint issues

How to verify that this has the expected result

  • Run npm run test and you should see one passing test
  • Run npm run lint and there should be no errors

@pkanal pkanal changed the title chore: add unit test setup chore: 🔧 add unit test setup Jan 3, 2024
@pkanal pkanal requested a review from a team January 3, 2024 17:03
@pkanal pkanal self-assigned this Jan 3, 2024
@pkanal pkanal added this to the Alpha milestone Jan 3, 2024
@pkanal pkanal marked this pull request as ready for review January 3, 2024 17:03
@pkanal pkanal requested a review from a team as a code owner January 3, 2024 17:03
@pkanal pkanal added type: maintenance The necessary chores to keep the dust off. no-changelog Omit this PR from changelog/release notes. version: no bump A PR with maintenance or doc changes that aren't included in a release. labels Jan 3, 2024
@pkanal pkanal mentioned this pull request Jan 3, 2024
Merged
@pkanal pkanal merged commit 6b25502 into main Jan 3, 2024
4 checks passed
@pkanal pkanal deleted the purvi/setup-unit-tests branch January 3, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjayaram mjayaram mjayaram approved these changes

Assignees

@pkanal pkanal

Labels
no-changelog Omit this PR from changelog/release notes. type: maintenance The necessary chores to keep the dust off. version: no bump A PR with maintenance or doc changes that aren't included in a release.
Projects
None yet
Milestone
Alpha
Development

Successfully merging this pull request may close these issues.

[maint] Add unit tests
2 participants
@pkanal @mjayaram