maint(deps): bump the otel group in /packages/honeycomb-opentelemetry-web with 8 updates #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![dependabot[bot]](https://avatars.githubusercontent.com/in/29110?s=60&v=4){kind=small}
|
Dependabot tried to add |
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/packages/honeycomb-opentelemetry-web/otel-bec207f2bd
branch
from
2730e27
to
9ebff50
Compare
Bumps the otel group in /packages/honeycomb-opentelemetry-web with 8 updates: | Package | From | To | | --- | --- | --- | | [@opentelemetry/auto-instrumentations-web](https://github.com/open-telemetry/opentelemetry-js-contrib) | `0.41.0` | `0.42.0` | | [@opentelemetry/core](https://github.com/open-telemetry/opentelemetry-js) | `1.26.0` | `1.27.0` | | [@opentelemetry/exporter-trace-otlp-http](https://github.com/open-telemetry/opentelemetry-js) | `0.53.0` | `0.54.0` | | [@opentelemetry/instrumentation](https://github.com/open-telemetry/opentelemetry-js) | `0.53.0` | `0.54.0` | | [@opentelemetry/opentelemetry-browser-detector](https://github.com/open-telemetry/opentelemetry-js) | `0.53.0` | `0.54.0` | | [@opentelemetry/resources](https://github.com/open-telemetry/opentelemetry-js) | `1.26.0` | `1.27.0` | | [@opentelemetry/sdk-trace-base](https://github.com/open-telemetry/opentelemetry-js) | `1.26.0` | `1.27.0` | | [@opentelemetry/sdk-trace-web](https://github.com/open-telemetry/opentelemetry-js) | `1.26.0` | `1.27.0` | Updates `@opentelemetry/auto-instrumentations-web` from 0.41.0 to 0.42.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js-contrib/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js-contrib/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js-contrib@instrumentation-pg-v0.41.0...instrumentation-pg-v0.42.0) Updates `@opentelemetry/core` from 1.26.0 to 1.27.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@v1.26.0...v1.27.0) Updates `@opentelemetry/exporter-trace-otlp-http` from 0.53.0 to 0.54.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@experimental/v0.53.0...experimental/v0.54.0) Updates `@opentelemetry/instrumentation` from 0.53.0 to 0.54.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@experimental/v0.53.0...experimental/v0.54.0) Updates `@opentelemetry/opentelemetry-browser-detector` from 0.53.0 to 0.54.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@experimental/v0.53.0...experimental/v0.54.0) Updates `@opentelemetry/resources` from 1.26.0 to 1.27.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@v1.26.0...v1.27.0) Updates `@opentelemetry/sdk-trace-base` from 1.26.0 to 1.27.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@v1.26.0...v1.27.0) Updates `@opentelemetry/sdk-trace-web` from 1.26.0 to 1.27.0 - [Release notes](https://github.com/open-telemetry/opentelemetry-js/releases) - [Changelog](https://github.com/open-telemetry/opentelemetry-js/blob/main/CHANGELOG.md) - [Commits](open-telemetry/opentelemetry-js@v1.26.0...v1.27.0) --- updated-dependencies: - dependency-name: "@opentelemetry/auto-instrumentations-web" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: otel - dependency-name: "@opentelemetry/core" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: otel - dependency-name: "@opentelemetry/exporter-trace-otlp-http" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: otel - dependency-name: "@opentelemetry/instrumentation" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: otel - dependency-name: "@opentelemetry/opentelemetry-browser-detector" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: otel - dependency-name: "@opentelemetry/resources" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: otel - dependency-name: "@opentelemetry/sdk-trace-base" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: otel - dependency-name: "@opentelemetry/sdk-trace-web" dependency-type: direct:production update-type: version-update:semver-minor dependency-group: otel ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/packages/honeycomb-opentelemetry-web/otel-bec207f2bd
branch
from
9ebff50
to
bb3f9ec
Compare
Comment on lines
+25
to
+30
| if (apiKey && !headers[TEAM_HEADER_KEY]) { | ||
| headers[TEAM_HEADER_KEY] = apiKey; | ||
| } | ||
| if (isClassic(apiKey) && options?.dataset) { | ||
| headers[DATASET_HEADER_KEY] = options?.dataset; | ||
| } |
There was a problem hiding this comment.
OTLPTraceExporter updated their headers type so that it is Record<string, string>, which means values can't be undefined anymore.
This code change now only adds the values if they exist.
| @@ -66,7 +66,7 @@ export interface HoneycombOptions extends Partial<WebSDKConfiguration> { | |||
| endpoint?: string; | |||
|
|
|||
| /** Optionally pass extra headers to the exporter. Commonly used if sending to a collector that requires authentication */ | |||
| headers?: { [key: string]: string | number }; | |||
| headers?: { [key: string]: string }; | |||
There was a problem hiding this comment.
Technically this is a breaking change 😭
The alternative is to map over options.headers in the configureHeaders function above and stringify any numeric values we get.
That said, I would rather we stick to the otel API as closely as possible.
Thoughts?
There was a problem hiding this comment.
I guess were still labeled as experimental but also we have this in the readme
Data shapes are stable and safe for production
If its not too hard then massaging the values as we are already doing a little seems ok.
But also I think it's fine to have this breaking change and call it out in the release notes. Maybe point fingers at the otel package that caused it as it looks like none of the packages increment a major version number for this
There was a problem hiding this comment.
Under semver, if you're still 0.x, breaking changes can be included in a change in the minor version (ie. 0.84 can contain breaking changes from version 0.83, which is exactly what happened in this PR and captured in their changelog here.
I'll merge this change as-is and link back to the OTel change. I'm also opening an issue against otel-js to update their changelog.
There was a problem hiding this comment.
martin308
approved these changes
Nov 5, 2024
| @@ -66,7 +66,7 @@ export interface HoneycombOptions extends Partial<WebSDKConfiguration> { | |||
| endpoint?: string; | |||
|
|
|||
| /** Optionally pass extra headers to the exporter. Commonly used if sending to a collector that requires authentication */ | |||
| headers?: { [key: string]: string | number }; | |||
| headers?: { [key: string]: string }; | |||
There was a problem hiding this comment.
I guess were still labeled as experimental but also we have this in the readme
Data shapes are stable and safe for production
If its not too hard then massaging the values as we are already doing a little seems ok.
But also I think it's fine to have this breaking change and call it out in the release notes. Maybe point fingers at the otel package that caused it as it looks like none of the packages increment a major version number for this
MustafaHaddara
added
breaking-change
MustafaHaddara
deleted the
dependabot/npm_and_yarn/packages/honeycomb-opentelemetry-web/otel-bec207f2bd
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the otel group in /packages/honeycomb-opentelemetry-web with 8 updates:
0.41.00.42.01.26.01.27.00.53.00.54.00.53.00.54.00.53.00.54.01.26.01.27.01.26.01.27.01.26.01.27.0Updates
@opentelemetry/auto-instrumentations-webfrom 0.41.0 to 0.42.0Commits
0af1b70chore: release main (#2211)71c15d5feat: update otel core dependencies (#2257)54d0510chore(instr-undici): Fix homepage url (#2252)7d6ddeafix(host-metrics): macOS bundling fix (#2071)7272ca8fix: Update Azure Functions Detector Collected Attributes (#2233)0078d0cchore(lint): refactor Markdown linting to use markdownlint-cli2 (#2234)50ff98bfeat(instrumentation-document-load): Add ability to disable span events (#2188)91dec9cremove link to non existing file (#2246)040eaa6fix: semconv alignment & listed in README (#2240)27d6503test: minor cleanup to pino ESM test (#2241)Updates
@opentelemetry/corefrom 1.26.0 to 1.27.0Release notes
Sourced from
@opentelemetry/core's releases.Changelog
Sourced from
@opentelemetry/core's changelog.Commits
eb3ca4fchore: prepare next release (#5068)6fee82dchore: add@maryliagto approvers (#5083)50d59cafeat(instrumentation-http)!: remove deprecated ignore options (#5085)4497ee3Added limitation in ot-shim readme (#5072)006fe44chore: move xray and xray-lambda propagators to contrib (#4966)330172cfix(instrumentation-http): add server attributes after they become available ...55a1fc8fix(instrumentation-http): fix http/https ESM instr for 'import defaultExport...5e17361chore(deps): update dependency chromedriver to v130 (#5080)be1737fchore: add markdown lint check to default lint command (#5074)c208991test: use venv in w3c trace context test script (#5071)Updates
@opentelemetry/exporter-trace-otlp-httpfrom 0.53.0 to 0.54.0Release notes
Sourced from
@opentelemetry/exporter-trace-otlp-http's releases.... (truncated)
Commits
eb3ca4fchore: prepare next release (#5068)6fee82dchore: add@maryliagto approvers (#5083)50d59cafeat(instrumentation-http)!: remove deprecated ignore options (#5085)4497ee3Added limitation in ot-shim readme (#5072)006fe44chore: move xray and xray-lambda propagators to contrib (#4966)330172cfix(instrumentation-http): add server attributes after they become available ...55a1fc8fix(instrumentation-http): fix http/https ESM instr for 'import defaultExport...5e17361chore(deps): update dependency chromedriver to v130 (#5080)be1737fchore: add markdown lint check to default lint command (#5074)c208991test: use venv in w3c trace context test script (#5071)Updates
@opentelemetry/instrumentationfrom 0.53.0 to 0.54.0Release notes
Sourced from
@opentelemetry/instrumentation's releases.... (truncated)
Commits
eb3ca4fchore: prepare next release (#5068)6fee82dchore: add@maryliagto approvers (#5083)50d59cafeat(instrumentation-http)!: remove deprecated ignore options (#5085)4497ee3Added limitation in ot-shim readme (#5072)006fe44chore: move xray and xray-lambda propagators to contrib (#4966)330172cfix(instrumentation-http): add server attributes after they become available ...55a1fc8fix(instrumentation-http): fix http/https ESM instr for 'import defaultExport...5e17361chore(deps): update dependency chromedriver to v130 (#5080)be1737fchore: add markdown lint check to default lint command (#5074)c208991test: use venv in w3c trace context test script (#5071)Updates
@opentelemetry/opentelemetry-browser-detectorfrom 0.53.0 to 0.54.0Release notes
Sourced from
@opentelemetry/opentelemetry-browser-detector's releases.... (truncated)
Commits
eb3ca4fchore: prepare next release (#5068)6fee82dchore: add@maryliagto approvers (#5083)50d59cafeat(instrumentation-http)!: remove deprecated ignore options (#5085)4497ee3Added limitation in ot-shim readme (#5072)006fe44chore: move xray and xray-lambda propagators to contrib (#4966)330172cfix(instrumentation-http): add server attributes after they become available ...55a1fc8fix(instrumentation-http): fix http/https ESM instr for 'import defaultExport...5e17361chore(deps): update dependency chromedriver to v130 (#5080)be1737fchore: add markdown lint check to default lint command (#5074)c208991test: use venv in w3c trace context test script (#5071)Updates
@opentelemetry/resourcesfrom 1.26.0 to 1.27.0Release notes
Sourced from
@opentelemetry/resources's releases.Changelog
Sourced from
@opentelemetry/resources's changelog.Commits
eb3ca4fchore: prepare next release (#5068)6fee82dchore: add@maryliagto approvers (#5083)50d59cafeat(instrumentation-http)!: remove deprecated ignore options (#5085)4497ee3Added limitation in ot-shim readme (#5072)006fe44chore: move xray and xray-lambda propagators to contrib (#4966)330172cfix(instrumentation-http): add server attributes after they become available ...55a1fc8fix(instrumentation-http): fix http/https ESM instr for 'import defaultExport...5e17361chore(deps): update dependency chromedriver to v130 (#5080)be1737fchore: add markdown lint check to default lint command (#5074)c208991test: use venv in w3c trace context test script (#5071)Updates
@opentelemetry/sdk-trace-basefrom 1.26.0 to 1.27.0Release notes
Sourced from
@opentelemetry/sdk-trace-base's releases.Changelog
Sourced from
@opentelemetry/sdk-trace-base's changelog.Commits
eb3ca4fchore: prepare next release (#5068)6fee82dchore: add@maryliagto approvers (#5083)50d59cafeat(instrumentation-http)!: remove deprecated ignore options (#5085)4497ee3Added limitation in ot-shim readme (#5072)006fe44chore: move xray and xray-lambda propagators to contrib (#4966)330172cfix(instrumentation-http): add server attributes after they become available ...55a1fc8fix(instrumentation-http): fix http/https ESM instr for 'import defaultExport...5e17361chore(deps): update dependency chromedriver to v130 (#5080)be1737fchore: add markdown lint check to default lint command (#5074)c208991test: use venv in w3c trace context test script (#5071)Updates
@opentelemetry/sdk-trace-webfrom 1.26.0 to 1.27.0Release notes
Sourced from
@opentelemetry/sdk-trace-web's releases.